fix(app): suppress review sidebar hydration motion#35368
Open
opencode-agent[bot] wants to merge 1 commit into
Open
fix(app): suppress review sidebar hydration motion#35368opencode-agent[bot] wants to merge 1 commit into
opencode-agent[bot] wants to merge 1 commit into
Conversation
opencode-agent
Bot
force-pushed
the
review-sidebar-hydration
branch
from
213e725 to
517742f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Electron reads persisted UI state asynchronously. When a hidden review file tree remounted, it first rendered with the default open state and then restored the saved closed state, replaying the width transition.
Discord context: https://discord.com/channels/1391832426048651334/1523037783416115324
Tests
bun typecheck(packages/app)bun run test:unit(packages/app) — 514 passedbun typecheck(packages/session-ui)bun test(packages/session-ui) — 57 passed