fix(opencode): unignore build-node.ts in gitignore#35833
Open
zhangpaopao0609 wants to merge 4 commits into
Open
fix(opencode): unignore build-node.ts in gitignore#35833zhangpaopao0609 wants to merge 4 commits into
zhangpaopao0609 wants to merge 4 commits into
Conversation
The script/build-*.ts pattern hid source build scripts required by desktop prebuild/predev and package build commands. Co-authored-by: Cursor <cursoragent@cursor.com>
Keep script/build-*.ts for ephemeral build wrappers added in anomalyco#22652, but except script/build-node.ts which is committed source required by desktop prebuild/predev and the node build path. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #35722
Type of change
What does this PR do?
packages/opencode/.gitignorehas ascript/build-*.tsline. That glob matchesscript/build-node.ts, which is a committed source script (not a generated file). It is invoked bypackages/desktop/scripts/prebuild.tsandpredev.tsviabun script/build-node.ts, so ignoring it means a fresh clone / desktop build can lose or fail to track that file.The
script/build-*.tsrule was added in #22652 alongside other ephemeral-file ignores, so I kept the rule and only added a negation!script/build-node.tsinstead of removing the whole line. This preserves the original intent (ignore ad-hocbuild-*.tswrappers) while keeping the one real source file tracked. Notescript/build.tsis not affected by the glob at all, sincebuild-*only matches the hyphenated form.How did you verify your code works?
Checked the ignore behavior locally with
git check-ignore -v:script/build-node.ts-> no longer ignored (negation wins)script/build-foo.ts-> still ignored byscript/build-*.tsscript/build.ts-> not matched by the glob, unaffectedScreenshots / recordings
Not a UI change.
Checklist
Made with Cursor