use acp client tools if available#3955
Conversation
|
@haoxiangliew i was thinking about doing this, we should probably disable the opencode write tools then if the ACP provided ones are avialable no? |
|
to work with our tools & prompt I think we should just make the acp tools be called the exact same thing with the same prompts ideally. I think you could import the existing tools, and override / copy from them so that you only change the execute portions also you need to remember to keep the permissions system in place too |
take PR feedback into account: - Import existing tools and only modify `execute()` - No prompt change needed, reads, edits, and writes are executed as-is with a different interface - Keep permissions refactor ACP tools
25e6929 to
e4f4bbe
Compare
we don't need ACP for "does a file exist"
dd29567 to
35203c5
Compare
remove unused import remove unused import
35203c5 to
e1b0ab8
Compare
went thru a couple iterations on the design to get this done as cleanly as possible:
lmk what u think 👍 |
|
left a couple comments here. Also I'm gonna merge dev into your branch there was a bug in one of the tests that causes CI to run for a longgg time |
f1dc981 to
3e15a39
Compare
df8bdf9 to
0dd5039
Compare
f8ee907 to
6a9856d
Compare
00637c0 to
71e0ba2
Compare
f1ae801 to
08fa7f7
Compare
|
Closing this pull request because it has had no updates for more than 60 days. If you plan to continue working on it, feel free to reopen or open a new PR. |
Delegates file
reads,edits, andwritesto the ACP Client, if the ACP Client (such as Zed) supports these modifications.Brings
opencode acpmore in-line with@zed-industries/claude-code-acp