core(renderer): handle ANSI text written to stdout in split-footer mode#1108
Open
justjake wants to merge 4 commits into
Open
core(renderer): handle ANSI text written to stdout in split-footer mode#1108justjake wants to merge 4 commits into
justjake wants to merge 4 commits into
Conversation
justjake
requested review from
Hona,
kommander,
msmps and
simonklee
as code owners
Collaborator
|
@simonklee needs to check that when he's back |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
externalOutputRendering: "terminal-native"in CliRendererConfig, commit bytes written to captured stdin with minimal transformation, instead of re-rendering them.In this mode, we compute the layout effect of each chunk by splitting on
\n, then usingstrip-ansiandstring-widthto get the width of the line before wrapping.The outcome is that ANSI styling bytes written to stdout are rendered by the terminal itself without needing to implement ANSI->OpenTUI conversion.
Before (
bun run packages/examples/src/split-footer-streaming-demo.ts):After (
OTUI_SPLIT_STREAMING_DEMO_RENDERING=terminal-native bun run packages/examples/src/split-footer-streaming-demo.ts):