feat/converter : refacto

Author: Issam Kadar

converter/converter/cisu/resources_status/resources_status_converter.py

@@ -39,10 +39,31 @@ def from_rs_to_cisu(
         if rs_ri_msg is None:
             raise ValueError(f"No RS-RI found for caseId: {case_id!r}")
 
+        rs_ri = rs_ri_msg.payload
+        cls.check_resource_belongs_to_case(rs_ri, current_use_case)
+
+        rs_sr_use_cases = [
+            cls.copy_rs_input_use_case_content(pm.payload) for pm in persisted_rs_sr
+        ]
+        rs_sr_use_cases.append(current_use_case)
+
+        output_json = ResourcesInfoCISUConverter.copy_rs_input_content(rs_ri)
+        rs_ri_use_case = ResourcesInfoCISUConverter.copy_rs_input_use_case_content(
+            rs_ri
+        )
+        enriched = enrich_rs_ri_with_rs_srs(rs_ri_use_case, rs_sr_use_cases)
+
+        return ResourcesInfoCISUConverter.convert_single_rs_ri(output_json, enriched)
+
+    @classmethod
+    def check_resource_belongs_to_case(
+        cls, rs_ri: Dict[str, Any], rs_sr_use_case: Dict[str, Any]
+    ) -> None:
+        case_id = get_field_value(rs_sr_use_case, ResourcesStatusConstants.CASE_ID)
         resource_id = get_field_value(
-            current_use_case, ResourcesStatusConstants.RESOURCE_ID
+            rs_sr_use_case, ResourcesStatusConstants.RESOURCE_ID
         )
-        rs_ri = rs_ri_msg.payload
+
         rs_ri_content = ResourcesInfoCISUConverter.copy_rs_input_use_case_content(rs_ri)
         resources = (
             get_field_value(rs_ri_content, ResourcesInfoCISUConstants.RESOURCE_PATH)
@@ -56,16 +77,3 @@ def from_rs_to_cisu(
             raise ValueError(
                 f"Resource '{resource_id}' from RS-SR not found in RS-RI for caseId '{case_id}'"
             )
-
-        rs_sr_use_cases = [
-            cls.copy_rs_input_use_case_content(pm.payload) for pm in persisted_rs_sr
-        ]
-        rs_sr_use_cases.append(current_use_case)
-
-        output_json = ResourcesInfoCISUConverter.copy_rs_input_content(rs_ri)
-        rs_ri_use_case = ResourcesInfoCISUConverter.copy_rs_input_use_case_content(
-            rs_ri
-        )
-        enriched = enrich_rs_ri_with_rs_srs(rs_ri_use_case, rs_sr_use_cases)
-
-        return ResourcesInfoCISUConverter.convert_single_rs_ri(output_json, enriched)