Skip to content

Commit cb5258a

Browse files
committed
feat(converter): update enrich_rs_ri_with_rs_srs usage in from_rs_to_cisu
1 parent 5211a96 commit cb5258a

2 files changed

Lines changed: 27 additions & 14 deletions

File tree

converter/converter/cisu/resources_info/resources_info_cisu_converter.py

Lines changed: 12 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -227,19 +227,24 @@ def from_rs_to_cisu(cls, edxl_json: Dict[str, Any]) -> Dict[str, Any]:
227227

228228
logger.info("Converting from RS to CISU format for Resources Info message.")
229229
logger.debug(f"Message content: {edxl_json}")
230+
231+
logger.info(
232+
"Received RS-RI message with distributionID: %s for CISU conversion",
233+
edxl_json.get("distributionID"),
234+
)
235+
230236
output_json = cls.copy_rs_input_content(edxl_json)
231237
current_use_case = cls.copy_rs_input_use_case_content(edxl_json)
232238

233239
case_id = get_field_value(current_use_case, "caseId")
234240

235241
_, persisted_rs_sr = get_rs_messages_by_case_id(case_id)
236-
rs_sr_use_cases = [
237-
# Hardcoded RS_SR use case to avoid circular dependency
238-
# TODO: Fix
239-
cls._copy_input_use_case_content(pm.payload, "resourcesStatus")
240-
for pm in persisted_rs_sr
241-
]
242-
enriched = enrich_rs_ri_with_rs_srs(current_use_case, rs_sr_use_cases)
242+
rs_sr_edxls = [pm.payload for pm in persisted_rs_sr]
243+
244+
enriched = enrich_rs_ri_with_rs_srs(
245+
rs_ri_edxl=edxl_json,
246+
rs_sr_edxl_list=rs_sr_edxls,
247+
)
243248

244249
return cls.convert_single_rs_ri(output_json, enriched)
245250

converter/converter/cisu/resources_status/resources_status_converter.py

Lines changed: 15 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,10 @@
1515

1616
from converter.utils import get_field_value
1717

18+
import logging
19+
20+
logger = logging.getLogger(__name__)
21+
1822

1923
class ResourcesStatusConverter(BaseCISUConverter):
2024
@classmethod
@@ -29,6 +33,11 @@ def get_cisu_message_type(cls) -> str:
2933
def from_rs_to_cisu(
3034
cls, edxl_json: Dict[str, Any]
3135
) -> Dict[str, Any] | list[Dict[str, Any]]:
36+
logger.info(
37+
"Received RS-SR message with distributionID: %s for CISU conversion",
38+
edxl_json.get("distributionID"),
39+
)
40+
3241
current_use_case = cls.copy_rs_input_use_case_content(edxl_json)
3342
case_id = get_field_value(current_use_case, ResourcesStatusConstants.CASE_ID)
3443

@@ -38,15 +47,14 @@ def from_rs_to_cisu(
3847

3948
rs_ri = rs_ri_msg.payload
4049

41-
rs_sr_use_cases = [
42-
cls.copy_rs_input_use_case_content(pm.payload) for pm in persisted_rs_sr
43-
]
44-
rs_sr_use_cases.append(current_use_case)
50+
rs_sr_edxl_list = [pm.payload for pm in persisted_rs_sr]
51+
rs_sr_edxl_list.append(edxl_json)
4552

4653
output_json = ResourcesInfoCISUConverter.copy_rs_input_content(rs_ri)
47-
rs_ri_use_case = ResourcesInfoCISUConverter.copy_rs_input_use_case_content(
48-
rs_ri
54+
55+
enriched = enrich_rs_ri_with_rs_srs(
56+
rs_ri_edxl=rs_ri,
57+
rs_sr_edxl_list=rs_sr_edxl_list,
4958
)
50-
enriched = enrich_rs_ri_with_rs_srs(rs_ri_use_case, rs_sr_use_cases)
5159

5260
return ResourcesInfoCISUConverter.convert_single_rs_ri(output_json, enriched)

0 commit comments

Comments
 (0)