Skip to content

Converter : Replacement du champ missionId par operationId dans le RC-RI #404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Clemsazert merged 2 commits into from
Apr 28, 2026
Merged

Converter : Replacement du champ missionId par operationId dans le RC-RI #404

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e3499be
chore(converter): replace missionId by operation in RC-RI v3 example
Clemsazert Apr 24, 2026
7e3e12a
feat(converter): translate missionId to operationId
Clemsazert Apr 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions converter/converter/cisu/resources_info/resources_info_cisu_constants.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ class ResourcesInfoCISUConstants:
RESOURCE_PATH = "$.resource"
STATE_PATH = "$.state"
VEHICLE_TYPE_PATH = "$.vehicleType"
MISSION_ID_PATH = "$.missionId"
OPERATION_ID_PATH = "$.operationId"

CASE_ID_FIELD = "caseId"
RESOURCE_ID_KEY = "resourceId"
Expand Down
18 changes: 17 additions & 1 deletion converter/converter/cisu/resources_info/resources_info_cisu_converter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
get_last_rc_ri_by_case_id,
get_rs_messages_by_case_id,
)
from converter.utils import get_field_value, set_value, delete_paths
from converter.utils import get_field_value, set_value, delete_paths, switch_field_name
import logging

logger = logging.getLogger(__name__)
Expand Down Expand Up @@ -70,6 +70,13 @@ def _build_rs_ri_from_cisu(cls, edxl_json: Dict[str, Any]) -> Dict[str, Any]:
# RS-RI does not carry GPS position — remove it if present
delete_paths(resource, [ResourcesInfoCISUConstants.POSITION_KEY])

# Map operationId to missionId
switch_field_name(
resource,
ResourcesInfoCISUConstants.OPERATION_ID_PATH,
ResourcesInfoCISUConstants.MISSION_ID_PATH,
)

return cls.format_rs_output_json(output_json, output_use_case_json)

@classmethod
Expand Down Expand Up @@ -317,13 +324,22 @@ def _convert_resources_to_cisu(
cls._translate_to_cisu_vehicle_type(resource)
cls._keep_last_state(resource)
cls._remove_patient_id(resource)
cls._replace_operation_id_by_mission_id(resource)

converted_resources.append(resource)
except ConversionError:
continue

return converted_resources

@classmethod
def _replace_operation_id_by_mission_id(cls, resource):
switch_field_name(
resource,
ResourcesInfoCISUConstants.MISSION_ID_PATH,
ResourcesInfoCISUConstants.OPERATION_ID_PATH,
)

@classmethod
def _remove_patient_id(cls, resource):
delete_paths(resource, [ResourcesInfoCISUConstants.PATIENT_ID_KEY])
Expand Down
2 changes: 1 addition & 1 deletion converter/tests/fixtures/RC-RI/RC-RI_V3.0_exhaustive_fill.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
"resourceId": "fr.fire.sis076.cgo-076.resource.VSAV3A",
"requestId": "fr.fire.sis076.cgo-076.request.177",
"centerName": "Centre de Secours 76 - A",
"missionId": "fr.fire.sis076.cgo-076.mission.177",
"operationId": "fr.fire.sis076.cgo-076.mission.177",
"centerCity": "75011",
"orgId": "fr.fire.sdis76.cgo-076",
"name": "VSAV 76 - 22D8",
Expand Down
Loading