Skip to content

fix: resolve code quality and maintainability concerns #409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sonarqube-agent wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: resolve code quality and maintainability concerns #409

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/test/java/com/hubsante/model/edxlhandler/EdxlHandlerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ public void deserializationOfMessageWithUnknownPropertyNotAtRootLevelFails() thr

@Test
@DisplayName("all json example files deserialize to same object xml example files deserialize to")
public void jsonAndXmlExampleFilesDeserializeToSameObject() {
void jsonAndXmlExampleFilesDeserializeToSameObject() {
String rootFolder = TestMessagesHelper.class.getClassLoader().getResource("sample/examples").getFile();

File[] subFolders = new File(rootFolder).listFiles(File::isDirectory);
Expand Down Expand Up @@ -239,7 +239,7 @@ public void jsonAndXmlExampleFilesDeserializeToSameObject() {

@Test
@DisplayName("serialized Xml EdxlMessages should contain xlink type")
public void serializedXmlEdxlMessagesShouldContainXlinkType() throws IOException {
void serializedXmlEdxlMessagesShouldContainXlinkType() throws IOException {
File jsonMessage = new File(TestMessagesHelper.class.getClassLoader().getResource("sample/valid/RC-EDA/RC-EDA.json").getFile());
String json = new String(Files.readAllBytes(jsonMessage.toPath()), StandardCharsets.UTF_8);
EdxlMessage message = converter.deserializeJsonEDXL(json);
Expand Down
2 changes: 1 addition & 1 deletion src/test/java/com/hubsante/model/validator/EnvelopeValidatorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ public class EnvelopeValidatorTest extends AbstractValidatorTest{

@Test
@DisplayName("check EDXL envelope schemas availability")
public void checkEdxlEnvelopeSchemasAvailability() {
void checkEdxlEnvelopeSchemasAvailability() {
assertDoesNotThrow(() -> new File(Thread.currentThread().getContextClassLoader()
.getResource("json-schema/" + ENVELOPE_SCHEMA).getFile()));

Expand Down
4 changes: 2 additions & 2 deletions src/test/java/com/hubsante/model/validator/UseCaseValidatorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,11 +37,11 @@
import static org.junit.jupiter.api.Assertions.fail;

@Slf4j
public class UseCaseValidatorTest extends AbstractValidatorTest {
class UseCaseValidatorTest extends AbstractValidatorTest {

@Test
@DisplayName("all examples files passing")
public void examplesBundlePassingTest() {
void examplesBundlePassingTest() {
String rootFolder = TestMessagesHelper.class.getClassLoader().getResource("sample/examples").getFile();
File[] subFolders = new File(rootFolder).listFiles(File::isDirectory);
assert subFolders != null;
Expand Down
Loading