Skip to content

Converter: VECTEUR_SAMU conversion handling#424

Open
Clemsazert wants to merge 6 commits into
mainfrom
converter/vectuer-samu-conversion-handling
Open

Converter: VECTEUR_SAMU conversion handling#424
Clemsazert wants to merge 6 commits into
mainfrom
converter/vectuer-samu-conversion-handling

Conversation

@Clemsazert

@Clemsazert Clemsazert commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

🔎 Détails

  • Révision des règles de traduction du champ vehicleType dans les ressources du messages RC-RI

    • Dans le sens 18 vers 15, tous les types de ressource sont traduits en "SIS"
    • Dans le sens 15 vers 18, tous les types de ressource sont traduits en "VECTEUR_SANTE"
  • Mise à jour des cas de tests unitaires pour la traduction du champ

☑️ Validation

Pre-requis :

  • Se placer sur la branche converter/vectuer-samu-conversion-handling
  • Lancer le converter

Sens 18 vers 15

# Génération du message RC-RI
export EDXL=$(jq -n \
  --slurpfile env tests/fixtures/EDXL/edxl_envelope_fire_to_health.json \
  --slurpfile msg ../src/main/resources/sample/examples/RC-RI/RC-RI_Incendie_RaymondeLECCIA.02.json \
  '($env[0].edxl | .content[0].jsonContent.embeddedJsonContent.message += $msg[0])')

# Conversion
curl -s -X POST http://localhost:8090/convert \
  -H "Content-Type: application/json" \
  -d "$(jq -n --argjson edxl "$EDXL" \
    '{sourceVersion:"v3", targetVersion:"v3", cisuConversion: "true", edxl:$edxl}')" \
  > res.json

# Vérification du contenu dans res.json : le champ vehicleType contient toujours "SIS"

Sens 15 vers 18

# Génération du message RS-RI
export EDXL=$(jq -n \
  --slurpfile env tests/fixtures/EDXL/edxl_envelope_health_to_fire.json \
  --slurpfile msg ../src/main/resources/sample/examples/RS-RI/RS-RI_partageRessources_MonsieurX.03.json \
  '($env[0].edxl | .content[0].jsonContent.embeddedJsonContent.message += $msg[0])')

# Conversion
curl -s -X POST http://localhost:8090/convert \
  -H "Content-Type: application/json" \
  -d "$(jq -n --argjson edxl "$EDXL" \
    '{sourceVersion:"v3", targetVersion:"v3", cisuConversion: "true", edxl:$edxl}')" \
  > res.json

# Vérification du contenu dans res.json : le champ vehicleType contient bien "VECTEUR_SANTE"

🔗 Ticket associé

Asana

@github-actions

Copy link
Copy Markdown

There is no coverage information present for the Files changed

Total Project Coverage 52.48% 🍏

@Clemsazert Clemsazert changed the title Converter/vectuer samu conversion handling Converter: VECTEUR_SAMU conversion handling Jun 16, 2026
@github-actions

Copy link
Copy Markdown

There is no coverage information present for the Files changed

Total Project Coverage 52.48% 🍏

@Clemsazert Clemsazert force-pushed the converter/vectuer-samu-conversion-handling branch from 2b900e5 to d4cd8ac Compare June 17, 2026 08:09
@github-actions

Copy link
Copy Markdown

Coverage

Converter - python code coverage
FileStmtsMissBranchBrPartCoverMissing
constants.py4000100% 
conversion_mixin.py2912196%26
converter.py6846194%25–26, 94–95
database.py32224431%12, 16, 18–21, 23, 25, 27, 29–38, 40–41, 49
logging_config.py3528294%29, 36
utils.py164374698%57, 108, 120
cisu
   base_cisu_converter.py3330090%7, 25, 31
   constants.py4000100% 
   identical_cisu_converter.py9000100% 
   utils.py15060100% 
cisu/create_case
   create_case_cisu_constants.py31000100% 
   create_case_cisu_converter.py145132199%112
cisu/reference
   reference_converter.py920077%9, 13
cisu/resources_info
   resources_info_cisu_constants.py12000100% 
   resources_info_cisu_converter.py171332398%175, 201, 389
   resources_info_cisu_helper.py49318293%58, 63, 66
cisu/resources_status
   resources_status_constants.py4000100% 
   resources_status_converter.py4114097%33
conversion_strategy
   cisu_conversion_strategy.py49222295%68, 93
   conversion_strategy.py7020100% 
   health_conversion_strategy.py460240100% 
models
   persisted_message.py13000100% 
repositories
   message_repository.py701212282%90–91, 98, 118–120, 122–123, 125, 171–173
versions
   base_message_converter.py831214285%13, 72–74, 86, 98, 102, 106, 110, 114, 118, 124
   error_converter.py510080%7
   identical_message_converter.py15000100% 
   utils.py26512280%34–37, 43
versions/create_case_health
   constants.py4000100% 
   create_case_health_converter.py1780800100% 
   create_case_health_update_converter.py5000100% 
versions/create_case_health/v1_v2
   constants.py17000100% 
   utils.py460222100% 
versions/create_case_health/v2_v3
   constants.py29000100% 
versions/geo_positions_update
   geo_positions_update_constants.py4000100% 
   geo_positions_update_converter.py49312493%31, 42, 79
versions/geo_resources_details
   geo_resources_details_constants.py4000100% 
   geo_resources_details_converter.py27040100% 
versions/reference
   reference_constants.py2000100% 
   reference_converter.py13000100% 
versions/resources_engagement
   resources_engagement_constants.py3000100% 
   resources_engagement_converter.py22021100% 
versions/resources_info
   resources_info_constants.py20000100% 
   resources_info_converter.py870363100% 
versions/resources_request
   resources_request_constants.py2000100% 
   resources_request_converter.py21000100% 
versions/resources_response
   resources_response_constants.py4000100% 
   resources_response_converter.py16020100% 
versions/resources_status
   resources_status_constants.py10000100% 
   resources_status_converter.py39000100% 
TOTAL1771804303895% 

@github-actions

Copy link
Copy Markdown

There is no coverage information present for the Files changed

Total Project Coverage 52.48% 🍏

@Clemsazert Clemsazert marked this pull request as ready for review June 17, 2026 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant