Skip to content

Feat/RC to RS conversion remove custom map freetext #428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
EliNoden merged 3 commits into from
Jul 1, 2026
Merged

Feat/RC to RS conversion remove custom map freetext #428

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d50dc79
deps(converter): activate pydantic.mypy
EliNoden Jul 1, 2026
17df8ef
feat(converter): remove freetext for victims count and mainVictim
EliNoden Jul 1, 2026
d5582f9
tests(converter): update snapshots
EliNoden Jul 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions converter/converter/cisu/create_case/create_case_cisu_converter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,6 @@ def add_victim_count_to_custom_map(json_data: Dict[str, Any]):
key="qualification.victims.count",
label="Nombre de patients-victimes",
value=count,
freetext="Indique le nombre de victimes selon la nomenclature du référentiel CISU",
)

add_to_custom_map(json_data, victim_count)
Expand All @@ -194,7 +193,6 @@ def add_main_victim_to_custom_map(json_data: Dict[str, Any]):
key="qualification.victims.mainVictim",
label="Type du patient-victime principal",
value=main_victim,
freetext="Identifie le type de la principale victime (celle dont l'état de santé provoque le déclenchement de l'envoi des secours) selon la nomenclature du référentiel CISU",
)

add_to_custom_map(json_data, main_victim)
Expand Down Expand Up @@ -251,7 +249,9 @@ def add_to_custom_map(json_data: Dict[str, Any], custom_map_entry: CustomMap):
if len(initial_custom_map_array) >= 3:
raise ValueError("The customMap already contains 3 items.")

initial_custom_map_array.append(custom_map_entry.model_dump())
initial_custom_map_array.append(
custom_map_entry.model_dump(exclude_none=True)
)

set_value(
json_data,
Expand All @@ -277,7 +277,6 @@ def add_call_taker_org_to_custom_map(json_data: Dict[str, Any]):
key="initialalert.calltaker.organization",
label="Identifiant SDIS",
value=calltaker_org,
freetext="",
)

add_to_custom_map(json_data, initialalert_calltaker)
Expand Down
5 changes: 5 additions & 0 deletions converter/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,11 @@ dev = [
"mongomock>=4.1.2",
]

[tool.mypy]
plugins = [
"pydantic.mypy"
]

[[tool.mypy.overrides]]
module = ["jsonpath_ng.*", "prometheus_flask_exporter.*"]
ignore_missing_imports = true
18 changes: 6 additions & 12 deletions converter/tests/cisu/__snapshots__/test_create_case_converter.ambr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,20 +146,17 @@
{
"key": "qualification.victims.count",
"value": "1",
"label": "Nombre de patients-victimes",
"freetext": "Indique le nombre de victimes selon la nomenclature du r\u00e9f\u00e9rentiel CISU"
"label": "Nombre de patients-victimes"
},
{
"key": "qualification.victims.mainVictim",
"value": "ADULTE",
"label": "Type du patient-victime principal",
"freetext": "Identifie le type de la principale victime (celle dont l'\u00e9tat de sant\u00e9 provoque le d\u00e9clenchement de l'envoi des secours) selon la nomenclature du r\u00e9f\u00e9rentiel CISU"
"label": "Type du patient-victime principal"
},
{
"key": "initialalert.calltaker.organization",
"value": "fr.health.samu440",
"label": "Identifiant SDIS",
"freetext": ""
"label": "Identifiant SDIS"
}
]
},
Expand Down Expand Up @@ -329,20 +326,17 @@
{
"key": "qualification.victims.count",
"value": "1",
"label": "Nombre de patients-victimes",
"freetext": "Indique le nombre de victimes selon la nomenclature du r\u00e9f\u00e9rentiel CISU"
"label": "Nombre de patients-victimes"
},
{
"key": "qualification.victims.mainVictim",
"value": "ADULTE",
"label": "Type du patient-victime principal",
"freetext": "Identifie le type de la principale victime (celle dont l'\u00e9tat de sant\u00e9 provoque le d\u00e9clenchement de l'envoi des secours) selon la nomenclature du r\u00e9f\u00e9rentiel CISU"
"label": "Type du patient-victime principal"
},
{
"key": "initialalert.calltaker.organization",
"value": "fr.health.samu440",
"label": "Identifiant SDIS",
"freetext": ""
"label": "Identifiant SDIS"
}
]
},
Expand Down
Loading