Feat/annuaire : migration du csv source de la configuration client vers du yaml#573
Open
issam71100 wants to merge 31 commits into
Open
Feat/annuaire : migration du csv source de la configuration client vers du yaml#573issam71100 wants to merge 31 commits into
issam71100 wants to merge 31 commits into
Conversation
added 7 commits
May 11, 2026 15:38
issam71100
changed the title
added 19 commits
May 12, 2026 14:34
…IR+FILENAME into VALUES_PATH
issam71100
changed the title
Clemsazert
reviewed
May 13, 2026
| ] | ||
| VALUES_DEFAULT_DIR = "/config/topology" | ||
| VALUES_FILENAME = "values.yaml" | ||
| VALUES_PATH = os.path.join( |
Contributor
There was a problem hiding this comment.
Est ce qu'on ne pourrait pas passer le chemin entier ? Pour voir plus de controle dessus via une variable d'environnement et créer un comportement local plus souple ?
| def setUp(self): | ||
| self.tempdir = tempfile.TemporaryDirectory() | ||
| self.csv_path = os.path.join(self.tempdir.name, CSV_FILENAME) | ||
| self._write_temp_csv( |
Contributor
There was a problem hiding this comment.
Le yaml qui a remplacé la fixture couvre-t-il les mêmes cas métier qu'auparavent ?
Contributor
There was a problem hiding this comment.
Ce ne sont pas les mêmes clients et la configuration associée pour chaque notamment.
| ] | ||
| ) | ||
| self.values_path = os.path.join(self.tempdir.name, "values.yaml") | ||
| shutil.copy(FIXTURE_PATH, self.values_path) |
Contributor
There was a problem hiding this comment.
On ne peut pas juste référencer un fichier de fixture via la variable d'environnement spécialement pour les tests ?
added 5 commits
May 18, 2026 17:11
…lients assertions
…omplete business case coverage
… original fixture cases
…ve unnecessary copy
Clemsazert
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔎 Détails
Cette PR migre la source de données de l'annuaire des clients depuis la configuration CSV (
rabbitmq.clients-configuration.csv) vers un fichier YAML (values.yaml).Objectifs :
VALUES_DIR(facilitation des déploiements multi-environnements).Principaux changements :
parse_csv,select_columns,csv.DictReader).annuaire.clients).TOPOLOGY_TO_LEGACY_KEYpour préserver les clés legacy (P: 15-15,P: 15-smur, etc.).fixtures/topology.yaml), couvrant les cas nominaux et les cas d'erreur.PyYAML==6.0.2.📄 Documentation
Structure YAML attendue (
values.yaml) :/config/topology/values.yamlVALUES_DIR=/mon/chemintools/annuaire/fixtures/topology.yaml📸 Captures d'écran
🔗 Ticket associé
Migrer la lecture de la configuration : du CSV vers le fichier YAML de topologie