This repository was archived by the owner on Jan 8, 2019. It is now read-only.
Added an override that allows for a time stamp to be set whilst logging#44
Open
wilfglover wants to merge 1 commit into
Open
Added an override that allows for a time stamp to be set whilst logging#44wilfglover wants to merge 1 commit into
wilfglover wants to merge 1 commit into
Conversation
…g, rather than always using the DateTime.Now
Owner
|
I don't think its a good approach to provide this option inside a constructor. I would rather do it via a property or a method, or directly use the intrinsic model to access this and other properties. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This idea came from wanting to only create a test report if the test fails, so we would store the test details locally then flush them out at the end of the test. This would have the time stamp being inaccurate since datetime.now is always used. This override allows for the time stamp to be stored along side the test details and flushed with it at the end of a test.