Skip to content

Fix cloud.common warning when turbo mode is disabled#638

Merged
mikemorency merged 4 commits into
ansible-collections:mainfrom
mikemorency:bugfix/637-cloudcommon-import
May 8, 2026
Merged

Fix cloud.common warning when turbo mode is disabled#638
mikemorency merged 4 commits into
ansible-collections:mainfrom
mikemorency:bugfix/637-cloudcommon-import

Conversation

@mikemorency
Copy link
Copy Markdown
Collaborator

@mikemorency mikemorency commented Apr 28, 2026

SUMMARY

Avoid importing cloud.common turbo exceptions unless turbo mode is explicitly enabled via VMWARE_ENABLE_TURBO

Related issue: #637

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
  • plugins/module_utils/vmware_rest.py
  • changelogs/fragments/637-cloud-common-warning.yml
ADDITIONAL INFORMATION

This PR description was generated by AI and reviewed/edited by the author.

Only import cloud.common turbo exceptions when VMWARE_ENABLE_TURBO is enabled, so normal module runs do not trigger cloud.common support warnings on Ansible 2.20. Add a changelog fragment linked to issue ansible-collections#637.
@mikemorency mikemorency requested review from mariolenz and p3ck April 28, 2026 15:45
@mikemorency mikemorency marked this pull request as ready for review April 28, 2026 15:45
Copy link
Copy Markdown
Collaborator

@mariolenz mariolenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

For the record, I thinks this has already been (mainly) done in #600. We've just overlooked this module util. So I guess "bugfix" is OK.

@mariolenz
Copy link
Copy Markdown
Collaborator

@mikemorency Do you know why the integration tests failed? It doesn't look like a real problem with this PR, at least not at first glance.

Has since been a temporary issue, or is there some basic problem in the CI?

@mikemorency mikemorency closed this May 8, 2026
@mikemorency mikemorency reopened this May 8, 2026
@mikemorency mikemorency merged commit a9eac6e into ansible-collections:main May 8, 2026
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants