Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions build-wheelhouse/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -233,16 +233,14 @@ runs:
PIPX_BIN_DIR: ${{ runner.temp }}/pipx/bin
PIPX_HOME : ${{ runner.temp }}/pipx/home

# NOTE: A virtual environment is needed regardless in all cases. In uv's case,
# the installation speed "uv pip" offers is what needs to be taken advantage of,
# using "uv venv" in a separate step is not necessary since "uv pip" will still
# work with existing virtual environments.
- name: "Create a virtual environment"
shell: bash
env:
USE_UV: ${{ inputs.use-uv }}
run: |
if [[ "$USE_UV" == 'true' ]]; then
uv venv .venv
else
python -m venv .venv
fi
python -m venv .venv

- name: "Set up virtual environment activation command"
id: virtual-environment-activation-command
Expand Down
14 changes: 6 additions & 8 deletions check-licenses/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -246,17 +246,15 @@ runs:
PIPX_BIN_DIR: ${{ runner.temp }}/pipx/bin
PIPX_HOME : ${{ runner.temp }}/pipx/home

- name: "Create a virtual environment"
# NOTE: A virtual environment is needed regardless in all cases. In uv's case,
# the installation speed "uv pip" offers is what needs to be taken advantage of,
# using "uv venv" in a separate step is not necessary since "uv pip" will still
# work with existing virtual environments.
- name: Create a virtual environment
if: inputs.skip-install == 'false'
shell: bash
env:
USE_UV: ${{ inputs.use-uv }}
run: |
if [[ "$USE_UV" == 'true' ]]; then
uv venv .venv
else
python -m venv .venv
fi
python -m venv .venv

- name: "Set up virtual environment activation command"
id: virtual-environment-activation-command
Expand Down
1 change: 1 addition & 0 deletions doc/source/changelog/1218.fixed.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Do not let uv create the virtual environment
Loading