refactor(cli): migrate dev command to devframe createDevServer#150
Merged
Conversation
Replace the manual h3 + startHttpAndWs orchestration with createDevServer + resolveDevServerPort from devframe/adapters/dev (vitejs/devtools#304). The factory now mounts the SPA, connection-meta endpoint, and WS RPC server itself, so we drop ~40 lines of bespoke wiring along with the sirv dependency. The build command is left as-is since createBuild does not yet forward setup flags. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
createDevServer+resolveDevServerPortfromdevframe/adapters/dev(introduced in vitejs/devtools#304). The factory mounts the SPA, the/.connection.jsonendpoint, and the WS RPC server itself, so ~40 lines of bespoke h3 wiring plus thesirvdependency go away.buildcommand is intentionally left on the manual path: devframe'screateBuilddoes not yet forwardflagstosetup, so adopting it would silently drop--config/--depth. Filed as a follow-up.rpcGroup.functions['nmi:get-payload'], with a one-line note explaining that the proxy returnsPromise<handler>.Test plan
pnpm typecheckpnpm lintpnpm test --run(36/36 unit)pnpm test:e2e— all 9 specs pass (3 dev, 3 build, 3 webcontainer)--port,--no-open,/.connection.jsonreturns{"backend":"websocket","websocket":<port>}, SPA serves on/,nmi:get-payloadwarms in the backgroundbin.mjs build --depth 3 --base /sub/still produces a valid static export🤖 Generated with Claude Code