Skip to content

ci: make sanitizer builds fail fast#1990

Draft
jac0626 wants to merge 3 commits into
antgroup:mainfrom
jac0626:codex/fail-on-sanitizer-log
Draft

ci: make sanitizer builds fail fast#1990
jac0626 wants to merge 3 commits into
antgroup:mainfrom
jac0626:codex/fail-on-sanitizer-log

Conversation

@jac0626
Copy link
Copy Markdown
Collaborator

@jac0626 jac0626 commented May 7, 2026

Summary

  • Make ASan/UBSan builds fail fast by replacing sanitizer recover mode with -fno-sanitize-recover=address,undefined.
  • Keep the test runner unchanged; sanitizer failures now produce a nonzero test process exit code directly.

Fixes #1960

Validation

  • git diff --check
  • bash -n scripts/testing/test_parallel_by_name.sh
  • Verified AppleClang accepts -fsanitize=address,undefined -fno-sanitize-recover=address,undefined -fno-sanitize=vptr.
  • Verified a temporary UBSan repro exits nonzero with the new fail-fast flags.

Signed-off-by: JiangChao <jacllovey@qq.com>
Copilot AI review requested due to automatic review settings May 7, 2026 08:31
@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented May 7, 2026

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Require kind label

Wonderful, this rule succeeded.
  • label~=^kind/

🟢 Require version label

Wonderful, this rule succeeded.
  • label~=^version/

🟢 Require linked issue for feature/bug PRs

Wonderful, this rule succeeded.
  • body~=(?im)(?:^|[\s\-\*])(?:close[sd]?|fix(?:e[sd])?|resolve[sd]?)\s*:?\s+(?:#\d+|[\w.\-]+/[\w.\-]+#\d+|https?://github\.com/[\w.\-]+/[\w.\-]+/issues/\d+)

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the parallel test script to redirect stderr to log files and introduces a post-test check for sanitizer errors (ASan, UBSan, LSan). If any sanitizer issues are detected, the script now prints the relevant log and ensures the overall test run is marked as a failure. The review feedback suggests using more idiomatic bash syntax for boolean flag evaluations to improve the robustness of the script.

Comment thread scripts/testing/test_parallel_by_name.sh Outdated
Comment thread scripts/testing/test_parallel_by_name.sh Outdated
Signed-off-by: JiangChao <jacllovey@qq.com>
@pull-request-size pull-request-size Bot added size/XS and removed size/S labels May 7, 2026
@jac0626 jac0626 changed the title ci: fail tests on sanitizer reports ci: make sanitizer builds fail fast May 7, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Signed-off-by: JiangChao <jacllovey@qq.com>
@jac0626 jac0626 requested a review from Copilot May 8, 2026 03:19
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Track UBSan runtime errors reported by x86 ASan CI

2 participants