ci: make sanitizer builds fail fast#1990
Draft
jac0626 wants to merge 3 commits into
Draft
Conversation
Signed-off-by: JiangChao <jacllovey@qq.com>
Contributor
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 Require kind labelWonderful, this rule succeeded.
🟢 Require version labelWonderful, this rule succeeded.
🟢 Require linked issue for feature/bug PRsWonderful, this rule succeeded.
|
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the parallel test script to redirect stderr to log files and introduces a post-test check for sanitizer errors (ASan, UBSan, LSan). If any sanitizer issues are detected, the script now prints the relevant log and ensures the overall test run is marked as a failure. The review feedback suggests using more idiomatic bash syntax for boolean flag evaluations to improve the robustness of the script.
Signed-off-by: JiangChao <jacllovey@qq.com>
Signed-off-by: JiangChao <jacllovey@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-fno-sanitize-recover=address,undefined.Fixes #1960
Validation
git diff --checkbash -n scripts/testing/test_parallel_by_name.sh-fsanitize=address,undefined -fno-sanitize-recover=address,undefined -fno-sanitize=vptr.