fix: remove forced UTC conversion for DateTimeKind.Unspecified DateTime

anthonyreilly · anthonyreilly · commit f53fb7b94900 · 2025-06-20T17:24:15.000-04:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -10,6 +10,11 @@
     - Tests target .NET Core 6.0-9.0
 * config: update SFDC API default to v64.0
 * content: Updated default SFDC object models in NetCoreForce.Models to SF API v64.0
+* fix: remove forced UTC conversion for DateTimeKind.Unspecified DateTimes.  
+        this caused inconsistent behavior between Windows and other platforms as under Windows it would end up adding a utc offset to the date.  
+        NetCoreForce.Client.Tests.DateFormatTests.FullDateFormatFromDateTime  
+        Expected: "2018-01-01T00:00:00+00:00"  
+        Actual:   "2018-01-01T00:00:00-05:00" (under Windows)  
 
 ### 2025-02-24 v5.0.0-Beta
 
diff --git a/src/NetCoreForce.Client/DateFormats.cs b/src/NetCoreForce.Client/DateFormats.cs
@@ -54,7 +54,7 @@ public static string FullDateString(DateTimeOffset dto)
         /// <returns></returns>
         public static string FullDateString(DateTime dt)
         {
-            return dt.ToUniversalTime().ToString(_FullFormat);
+            return dt.ToString(_FullFormat);
         }
 
         public static string FullDateString(DateTime dt, TimeSpan offset)

Original file line number	Diff line number	Diff line change
`@@ -54,7 +54,7 @@ public static string FullDateString(DateTimeOffset dto)`
`54`	`54`	`/// <returns></returns>`
`55`	`55`	`public static string FullDateString(DateTime dt)`
`56`	`56`	`{`
`57`		`- return dt.ToUniversalTime().ToString(_FullFormat);`
	`57`	`+ return dt.ToString(_FullFormat);`
`58`	`58`	`}`
`59`	`59`
`60`	`60`	`public static string FullDateString(DateTime dt, TimeSpan offset)`