fix(bedrock): detect region from AWS_DEFAULT_REGION and aws_profile arg#1553
Open
JiwaniZakir wants to merge 1 commit into
Open
fix(bedrock): detect region from AWS_DEFAULT_REGION and aws_profile arg#1553JiwaniZakir wants to merge 1 commit into
JiwaniZakir wants to merge 1 commit into
Conversation
_infer_region now checks AWS_DEFAULT_REGION in addition to AWS_REGION, and accepts the aws_profile argument so the correct boto3 session is used when a non-default profile is passed to AnthropicBedrock.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
_infer_regionfunction insrc/anthropic/lib/bedrock/_client.pyonly checkedAWS_REGIONand ignored the standardAWS_DEFAULT_REGIONenvironment variable, and did not pass theaws_profileargument to the boto3 session, so a non-default profile's region was never picked up. This PR addsAWS_DEFAULT_REGIONas a fallback afterAWS_REGION, updates_infer_regionto accept and forwardaws_profiletoboto3.Session, and threads that argument through bothAnthropicBedrockandAsyncAnthropicBedrock. Runpytest tests/lib/test_bedrock.pyto verify the newtest_region_infer_from_aws_default_region_envandtest_region_infer_from_aws_profile_argtests pass alongside the existing suite.Fixes #892