Commit 431b46d
fix(transcript_mirror): handle CancelledError in eager-flush done callback
The ``add_done_callback`` lambda on the eager-flush ``_flush_task``
called ``t.exception()`` unconditionally. In Python 3.8+,
``Task.exception()`` raises ``CancelledError`` for cancelled tasks, and
the raise from inside a done-callback surfaces as a noisy "Exception in
callback" log every time the SDK shuts down with pending eager flushes
(visible in #928's failing-test traceback).
Replace the lambda with a module-level ``_swallow_done_exception``
helper that no-ops on cancelled tasks and otherwise retrieves the
exception so asyncio doesn't warn about an unretrieved exception on a
fire-and-forget task.
Closes #930
Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>1 parent 9aafd84 commit 431b46d
2 files changed
Lines changed: 59 additions & 1 deletion
Lines changed: 12 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
33 | 33 | | |
34 | 34 | | |
35 | 35 | | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
36 | 47 | | |
37 | 48 | | |
38 | 49 | | |
| |||
88 | 99 | | |
89 | 100 | | |
90 | 101 | | |
91 | | - | |
| 102 | + | |
92 | 103 | | |
93 | 104 | | |
94 | 105 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
31 | 31 | | |
32 | 32 | | |
33 | 33 | | |
| 34 | + | |
34 | 35 | | |
35 | 36 | | |
36 | 37 | | |
| |||
504 | 505 | | |
505 | 506 | | |
506 | 507 | | |
| 508 | + | |
| 509 | + | |
| 510 | + | |
| 511 | + | |
| 512 | + | |
| 513 | + | |
| 514 | + | |
| 515 | + | |
| 516 | + | |
| 517 | + | |
| 518 | + | |
| 519 | + | |
| 520 | + | |
| 521 | + | |
| 522 | + | |
| 523 | + | |
| 524 | + | |
| 525 | + | |
| 526 | + | |
| 527 | + | |
| 528 | + | |
| 529 | + | |
| 530 | + | |
| 531 | + | |
| 532 | + | |
| 533 | + | |
| 534 | + | |
| 535 | + | |
| 536 | + | |
| 537 | + | |
| 538 | + | |
| 539 | + | |
| 540 | + | |
| 541 | + | |
| 542 | + | |
| 543 | + | |
| 544 | + | |
| 545 | + | |
| 546 | + | |
| 547 | + | |
| 548 | + | |
| 549 | + | |
| 550 | + | |
| 551 | + | |
| 552 | + | |
| 553 | + | |
507 | 554 | | |
508 | 555 | | |
509 | 556 | | |
| |||
0 commit comments