Commit 5620dec
committed
docs(examples): point Retention sections at delete_session_via_store, not delete_session
delete_session() is the pre-existing sync disk-path helper that os.remove()s
the local JSONL and never touches a SessionStore. The async store-backed
counterpart that actually calls store.delete() is delete_session_via_store().
A user following the old wording would call delete_session() expecting their
S3/Redis/Postgres data to be removed and only the local file would go.
Fixes 4 locations: README.md S3/Redis/Postgres Retention sections and the
s3_session_store.py module docstring. The corresponding SessionStore Protocol
docstring fix is in the base PR.1 parent 1c92ba7 commit 5620dec
2 files changed
Lines changed: 4 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
154 | 154 | | |
155 | 155 | | |
156 | 156 | | |
157 | | - | |
| 157 | + | |
158 | 158 | | |
159 | 159 | | |
160 | 160 | | |
| |||
250 | 250 | | |
251 | 251 | | |
252 | 252 | | |
253 | | - | |
| 253 | + | |
254 | 254 | | |
255 | 255 | | |
256 | 256 | | |
| |||
367 | 367 | | |
368 | 368 | | |
369 | 369 | | |
370 | | - | |
| 370 | + | |
371 | 371 | | |
372 | 372 | | |
373 | 373 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
39 | 39 | | |
40 | 40 | | |
41 | 41 | | |
42 | | - | |
| 42 | + | |
43 | 43 | | |
44 | 44 | | |
45 | 45 | | |
| |||
0 commit comments