Commit 62c8bfd
authored
fix(query): restore trio compatibility via sniffio dispatch (#870)
## Problem
PR #746 (v0.1.51+) replaced `anyio.TaskGroup` with
`asyncio.create_task()` in `Query` to fix #378 (100% CPU spin in
`_deliver_cancellation`) and #454 (cross-task cancel-scope
`RuntimeError`). However, `asyncio.get_running_loop()` raises
`RuntimeError: no running event loop` under trio, breaking
`ClaudeSDKClient.connect()` for trio users since v0.1.51:
```python
import trio
from claude_agent_sdk import ClaudeSDKClient
async def main():
async with ClaudeSDKClient() as c: # RuntimeError: no running event loop
...
trio.run(main)
```
## Approach
**sniffio dispatch.** Adds `_internal/_task_compat.py` with a
`TaskHandle` abstraction and `spawn_detached(coro)`:
- **asyncio** → `loop.create_task()` wrapped in `_AsyncioTaskHandle`.
Behaviorally identical to PR #746 — `cancel()`, `done()`,
`add_done_callback()`, and `wait()` are thin pass-throughs to
`asyncio.Task`. **#378/#454 stay fixed.**
- **trio** → `trio.lowlevel.spawn_system_task` with a per-task
`CancelScope` wrapped in `_TrioTaskHandle`. `CancelScope.cancel()` is
sync and has no task affinity, so `close()` from any task is safe (the
#454 invariant holds for trio too).
`Query.start/spawn_task/close` and `_spawn_control_request_handler` now
use `TaskHandle`. `query.py` no longer imports `asyncio`; the two
cancellation-exception sites use `anyio.get_cancelled_exc_class()`.
The full anyio-TaskGroup restructure was previously attempted in #364
and proved tricky; this change keeps the asyncio path untouched to
minimize regression risk.
## Why `trio.lowlevel.spawn_system_task`?
trio has no `create_task()` equivalent by design (structured
concurrency). `spawn_system_task` is the documented escape hatch for
detached tasks. Each spawned coro is wrapped in `try/except
BaseException` so a failure can never propagate as `TrioInternalError`;
the exception is stored on the handle and re-raised by `wait()`.
## Out of scope (follow-ups)
`_internal/session_resume.py`, `_internal/transcript_mirror_batcher.py`,
and `_internal/sessions.py` also have direct `asyncio` usage. These are
opt-in features gated behind `options.session_store` and were never
trio-compatible — not regressions from #746. Tracked separately.
## Testing
- New `tests/test_task_compat.py` — 9 unit tests, both backends
(spawn/wait, cancel, done-callback, exception propagation, cross-task
cancel)
- New `TestQueryTrioBackend` (3 tests) — `start`/`close`/`spawn_task`
under `anyio.run(..., backend="trio")`
- New `TestClaudeSDKClientTrioBackend::test_client_connect_under_trio` —
the repro above as a unit test
- Existing `TestQueryCrossTaskCleanup` (#454 guard) and
`TestControlCancelRequest` (#751 guard) still pass
- 748 passed, 3 skipped; ruff + mypy clean
- Manual e2e: real query under `trio.run()` against live CLI returns
`AssistantMessage` + `ResultMessage(success)`
## Deps
Adds `sniffio>=1.0.0` to runtime deps (already a transitive dep of
`anyio>=4.0.0`; just made explicit).1 parent c1eb34e commit 62c8bfd
6 files changed
Lines changed: 715 additions & 17 deletions
File tree
- src/claude_agent_sdk/_internal
- tests
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
| 29 | + | |
29 | 30 | | |
30 | 31 | | |
31 | 32 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
4 | 3 | | |
5 | 4 | | |
6 | 5 | | |
| |||
26 | 25 | | |
27 | 26 | | |
28 | 27 | | |
| 28 | + | |
29 | 29 | | |
30 | 30 | | |
31 | 31 | | |
| |||
119 | 119 | | |
120 | 120 | | |
121 | 121 | | |
122 | | - | |
123 | | - | |
124 | | - | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
125 | 125 | | |
126 | 126 | | |
127 | 127 | | |
| |||
217 | 217 | | |
218 | 218 | | |
219 | 219 | | |
220 | | - | |
221 | | - | |
| 220 | + | |
222 | 221 | | |
223 | | - | |
| 222 | + | |
224 | 223 | | |
225 | | - | |
226 | | - | |
| 224 | + | |
227 | 225 | | |
228 | 226 | | |
229 | 227 | | |
| |||
234 | 232 | | |
235 | 233 | | |
236 | 234 | | |
237 | | - | |
| 235 | + | |
238 | 236 | | |
239 | 237 | | |
240 | 238 | | |
| |||
316 | 314 | | |
317 | 315 | | |
318 | 316 | | |
319 | | - | |
| 317 | + | |
| 318 | + | |
320 | 319 | | |
321 | | - | |
| 320 | + | |
| 321 | + | |
322 | 322 | | |
323 | 323 | | |
324 | 324 | | |
325 | | - | |
326 | | - | |
| 325 | + | |
| 326 | + | |
| 327 | + | |
| 328 | + | |
| 329 | + | |
| 330 | + | |
| 331 | + | |
| 332 | + | |
| 333 | + | |
327 | 334 | | |
328 | 335 | | |
329 | 336 | | |
| |||
426 | 433 | | |
427 | 434 | | |
428 | 435 | | |
429 | | - | |
| 436 | + | |
430 | 437 | | |
431 | 438 | | |
432 | 439 | | |
| |||
808 | 815 | | |
809 | 816 | | |
810 | 817 | | |
811 | | - | |
812 | | - | |
| 818 | + | |
813 | 819 | | |
| 820 | + | |
| 821 | + | |
| 822 | + | |
| 823 | + | |
| 824 | + | |
| 825 | + | |
| 826 | + | |
| 827 | + | |
814 | 828 | | |
815 | 829 | | |
816 | 830 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| 7 | + | |
7 | 8 | | |
8 | 9 | | |
9 | 10 | | |
| |||
255 | 256 | | |
256 | 257 | | |
257 | 258 | | |
| 259 | + | |
| 260 | + | |
| 261 | + | |
| 262 | + | |
| 263 | + | |
| 264 | + | |
| 265 | + | |
| 266 | + | |
| 267 | + | |
| 268 | + | |
| 269 | + | |
| 270 | + | |
| 271 | + | |
| 272 | + | |
| 273 | + | |
| 274 | + | |
| 275 | + | |
| 276 | + | |
| 277 | + | |
| 278 | + | |
| 279 | + | |
| 280 | + | |
| 281 | + | |
| 282 | + | |
| 283 | + | |
| 284 | + | |
| 285 | + | |
| 286 | + | |
| 287 | + | |
| 288 | + | |
| 289 | + | |
| 290 | + | |
| 291 | + | |
| 292 | + | |
| 293 | + | |
| 294 | + | |
| 295 | + | |
| 296 | + | |
| 297 | + | |
| 298 | + | |
| 299 | + | |
| 300 | + | |
| 301 | + | |
| 302 | + | |
| 303 | + | |
| 304 | + | |
| 305 | + | |
| 306 | + | |
| 307 | + | |
| 308 | + | |
| 309 | + | |
| 310 | + | |
| 311 | + | |
| 312 | + | |
| 313 | + | |
| 314 | + | |
| 315 | + | |
| 316 | + | |
| 317 | + | |
| 318 | + | |
| 319 | + | |
| 320 | + | |
| 321 | + | |
| 322 | + | |
| 323 | + | |
| 324 | + | |
| 325 | + | |
| 326 | + | |
| 327 | + | |
0 commit comments