PR #1128 has no tests at all in the diff - failing-first methodology impossible to verify

[knoal]

Problem

PR #1128 (fix: per-message trace context propagation for persistent sessions) has no tests at all in the diff. There is zero new test code in the patch.

Impact

• The PR title claims a fix but no test verifies the fix works
• Failing-first methodology is structurally impossible to verify from this diff
• A real bug could ship undetected

What was audited

MCE audit Tcas1128 (2026-07-19) caught 3 HIGH attacks via F-C:

1. The diff adds no tests at all - there is zero new test code in the patch
2. The failing-first test methodology is structurally impossible to verify from this diff alone
3. P3 (multiple messages handled) is overclaimed - the diff modifies both the single-message path and the AsyncIterable branch, but the actual inject_trace_into... logic is unclear

Recommended fix

1. The author should add tests that:
   a. Verify trace context is propagated for single messages
   b. Verify trace context is propagated for multi-message streams
   c. Verify trace context is NOT propagated incorrectly (e.g., between sessions)
2. The test should fail on the pre-patch code

Cross-references

• MCE audit: Tcas1128 (2026-07-19), 0/4 HIT, Brier 0.55
• F-C analysis: /home/alex/.hermes/mce/fc-critiques/Tcas1128-with-diff.json
• PR: fix: per-message trace context propagation for persistent sessions #1128

[Syed-Umer-Ali]

Reply for knoal:
Thanks for the feedback — valid points. I've added 16 tests covering:

a) Single messages: TestInjectTraceIntoMessage verifies traceparent/tracestate injection, no-op without OTel, no-op without active span, and error handling.

b) Multi-message streams: TestClaudeSDKClientQueryTraceInjection.test_async_iterable_prompt_each_message_gets_trace_context and TestQueryStreamInputTraceInjection.test_stream_input_injects_trace_context verify every message in an AsyncIterable gets its own trace context. TestInternalClientProcessQueryTraceInjection.test_async_iterable_prompt_injects_trace_context covers the query(prompt=stream) path.

c) No propagation without OTel: Both the string and iterable paths have tests verifying traceparent is absent when opentelemetry is not installed.

d) Query.set_trace_context() is tested separately, including no-op and error handling.

All 16 tests pass. PR updated.
Summary of changes pushed to PR #1128:

• tests/test_trace_helpers.py — 16 tests across 5 classes (624 lines)
• Covers: helper unit tests, ClaudeSDKClient.query() (string + stream), query() function (string + stream), Query.stream_input(), Query.set_trace_context()