fix(transport): catch all TimeoutError variants in process termination escalation loop - #1155
Open
Echolonius wants to merge 1 commit into
Open
fix(transport): catch all TimeoutError variants in process termination escalation loop#1155Echolonius wants to merge 1 commit into
Echolonius wants to merge 1 commit into
Conversation
…n escalation loop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🐛 Fix: Catch All
TimeoutErrorVariants in Process Close Escalation Loop💡 Overview & Root Cause Analysis
In
src/claude_agent_sdk/_internal/transport/subprocess_cli.py, theclose()method runs inside a shielded cancel scope and usesanyio.fail_after(5)to enforce a graceful shutdown timeout, escalating fromwait()toterminate()and finallykill().However, the escalation loop previously caught only built-in
TimeoutErrorexplicitly (except TimeoutError:). Depending on the AnyIO version or backend context (asynciovstrio),anyio.fail_aftercan raiseanyio.TimeoutError. Catching(TimeoutError, getattr(anyio, "TimeoutError", TimeoutError))guarantees that the process termination escalation loop (terminate()->kill()) executes reliably across all Python runtime environments.🛠️ Solution
Updated the
exceptblocks inSubprocessCLITransport.close()to handle(TimeoutError, getattr(anyio, "TimeoutError", TimeoutError)).✅ Verification
uv run --with pytest --with pytest-asyncio --with trio pytest tests/test_transport.py).