feat: ClaudeSDKClient supports custom transport.#187
Merged
Conversation
Collaborator
|
"Commits must have verified signatures." Could you please re-push and address the lint errors? |
886268e to
0d5b0e6
Compare
Contributor
Author
I have repushed and fixed the lint issues. |
dicksontsai
approved these changes
Sep 29, 2025
dicksontsai
reviewed
Sep 29, 2025
Collaborator
dicksontsai
left a comment
There was a problem hiding this comment.
Looks like your commit still doesn't have a verified signature.
| """Initialize Claude SDK client.""" | ||
| if options is None: | ||
| options = ClaudeAgentOptions() | ||
| self.options = options | ||
| self._transport: Any | None = None | ||
| self._custom_transport = transport |
Collaborator
There was a problem hiding this comment.
Is self._custom_transport necessary?
Contributor
Author
There was a problem hiding this comment.
If _transport is assigned directly, the test case TestClaudeSDKClientEdgeCases.test_double_connect will fail. If there is no custom transport, client.connect() should ensure that the self._transport is renewed.
0d5b0e6 to
0cf9987
Compare
Collaborator
|
Thanks for your contribution! |
alva-bot01
approved these changes
Mar 24, 2026
alva-bot01
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
querysupports custom transport, but ClaudeSDKClient does not. So I add this feature. eg.