fix(parser): handle missing signature field in ThinkingBlock#786
Open
nanookclaw wants to merge 1 commit intoanthropics:mainfrom
Open
fix(parser): handle missing signature field in ThinkingBlock#786nanookclaw wants to merge 1 commit intoanthropics:mainfrom
nanookclaw wants to merge 1 commit intoanthropics:mainfrom
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a
KeyError: 'signature'crash inmessage_parser.pywhen the API returns athinkingcontent block without asignaturefield.Root Cause
message_parser.py:110uses a direct dict lookup:The Anthropic API can return thinking blocks without a
signaturein certain conditions:Fix
One-line change to use
.get()with an empty string default:Test
Added
test_parse_assistant_message_with_thinking_missing_signaturein the existing test suite — verifies that parsing succeeds (noKeyError) whensignatureis absent from a thinking block.All 453 existing tests pass.
Related
Fixes the
KeyError: 'signature'reported in #777 by @Zerolzj.