fix: use is not None for betas and plugins to distinguish unset from empty#803
Open
FuturizeRush wants to merge 1 commit intoanthropics:mainfrom
Open
fix: use is not None for betas and plugins to distinguish unset from empty#803FuturizeRush wants to merge 1 commit intoanthropics:mainfrom
FuturizeRush wants to merge 1 commit intoanthropics:mainfrom
Conversation
…m empty Same class of bug as anthropics#634 (tools) and anthropics#778 (setting_sources). `betas=[]` means "disable all betas" but the truthiness check treats [] as falsy, so --betas is never passed to the CLI. `plugins=[]` means "no plugins" but [] is falsy, so plugin dirs are never passed. The `tools` field was already fixed to use `is not None` (line 185). This aligns `betas` and `plugins` with the same pattern.
IgorTavcar
added a commit
to IgorTavcar/claude-agent-sdk-python
that referenced
this pull request
Apr 10, 2026
- anthropics#806: setting_sources=[] truthiness fix - anthropics#803: betas=[]/plugins=[] truthiness fix - anthropics#786: ThinkingBlock missing signature crash fix - anthropics#790: suppress ProcessError when result already received - anthropics#658: capture real stderr in ProcessError - anthropics#791: suppress stale task notifications between turns - anthropics#763: guard malformed CLAUDE_CODE_STREAM_CLOSE_TIMEOUT env var - anthropics#805: delete_session() cascades subagent transcript dir - anthropics#804: top-level skills option on ClaudeAgentOptions - anthropics#691: PostCompact hook event type support 479 tests passing, mypy clean, ruff clean. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix two remaining truthiness bugs in
subprocess_cli.py— same class as #634 (tools, fixed) and #778 (setting_sources, fixed).Bug
_build_command()uses truthiness checks forbetasandplugins, making empty lists indistinguishable fromNone(unset):Compare with the already-fixed
toolsfield on line 185:Fix
betas:is not None+ empty list sends--betas ""plugins:is not None(empty list = no plugins, loop body doesn't execute)Follows the same pattern established by the
toolsfix.Test plan
betas=None→ no--betasflag (unchanged)betas=[]→--betas ""(fixed — was silently skipped)betas=["beta1"]→--betas beta1(unchanged)plugins=None→ no--plugin-dirflags (unchanged)plugins=[]→ no--plugin-dirflags, but loop entered (fixed — was silently skipped)