Skip to content

Comments/reviews from deleted ("ghost") accounts crash the action (null author dereference) #1489

Description

@pa-arth

What happens: GitHub's GraphQL author field is null for any comment, review, PR, etc. whose account has been deleted. The action types these as non-null and dereferences author.login. This means one bad comment turns into "Failed to fetch PR/issue data" and the entire run fails.

Trigger: any PR/issue that has an above action from a deleted account. The filterCommentsByActor path (fetcher.ts) is only hit when include_/exclude_comments_by_actor is configured, so the exact exclude_comments_by_actor: '*[bot]' config from the docs is a guaranteed crash. Formatter crashes regardless of config.

Fix: treat null author like a GitHub ghost login. PR below.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingp2Non-showstopper bug or popular feature request

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions