Skip to content

fix: propagate curl exit code through pipe with set -o pipefail #1159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
qozle wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: propagate curl exit code through pipe with set -o pipefail #1159

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 20 additions & 3 deletions src/entrypoints/run.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,17 @@ async function installClaudeCode(): Promise<void> {
}

const claudeCodeVersion = "2.1.92";
const VERSION_RE = /^\d+\.\d+\.\d+$/;
if (!VERSION_RE.test(claudeCodeVersion)) {
throw new Error(
`Invalid claudeCodeVersion format: ${claudeCodeVersion}`,
);
}
console.log(`Installing Claude Code v${claudeCodeVersion}...`);

const homeBin = `${process.env.HOME}/.local/bin`;
const claudeBinary = `${homeBin}/claude`;

for (let attempt = 1; attempt <= 3; attempt++) {
console.log(`Installation attempt ${attempt}...`);
try {
Expand All @@ -70,7 +79,7 @@ async function installClaudeCode(): Promise<void> {
"bash",
[
"-c",
`curl -fsSL https://claude.ai/install.sh | bash -s -- ${claudeCodeVersion}`,
`set -o pipefail; curl -fsSL https://claude.ai/install.sh | bash -s -- ${claudeCodeVersion}`,
],
{ stdio: "inherit" },
);
Expand All @@ -81,8 +90,13 @@ async function installClaudeCode(): Promise<void> {
child.on("error", reject);
});
console.log("Claude Code installed successfully");
// Verify the binary actually landed where expected
if (!existsSync(claudeBinary)) {
throw new Error(
`Install exited successfully but Claude binary not found at ${claudeBinary}. The install script may have changed its output location.`,
);
}
// Add to PATH
const homeBin = `${process.env.HOME}/.local/bin`;
const githubPath = process.env.GITHUB_PATH;
if (githubPath) {
await appendFile(githubPath, `${homeBin}\n`);
Expand All @@ -95,7 +109,10 @@ async function installClaudeCode(): Promise<void> {
`Failed to install Claude Code after 3 attempts: ${error}`,
);
}
console.log("Installation failed, retrying...");
console.log(
`Installation attempt ${attempt} failed: ${error instanceof Error ? error.message : String(error)}`,
);
console.log("Retrying...");
await new Promise((resolve) => setTimeout(resolve, 5000));
}
}
Expand Down