fix: use -exist flag in ipset add to prevent duplicate entry errors#50293
Open
briancornally wants to merge 1 commit intoanthropics:mainfrom
Open
fix: use -exist flag in ipset add to prevent duplicate entry errors#50293briancornally wants to merge 1 commit intoanthropics:mainfrom
briancornally wants to merge 1 commit intoanthropics:mainfrom
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
tandon
added a commit
to tandon/claude-code
that referenced
this pull request
Apr 22, 2026
In the container, dig(1) can return duplicate A records for certain domains due to CNAME chain expansion. This causes ipset(8) to fail, and since set -e is set, abort the entire firewall setup, preventing the dev container from starting. Previous proposals (anthropics#50293, anthropics#42701) address this in two places by adding --exist to ipset add. My proposal addresses the root cause in one line by deduplicating dig output before it reaches ipset(8).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-existflag to bothipset addcalls in.devcontainer/init-firewall.shTest plan
init-firewall.shonce — verify it completes successfullyinit-firewall.sha second time — verify it no longer errors on duplicate ipset entries