fix: normalize whitespace in completion promise before comparison#52415
Open
sakal-s wants to merge 1 commit intoanthropics:mainfrom
Open
fix: normalize whitespace in completion promise before comparison#52415sakal-s wants to merge 1 commit intoanthropics:mainfrom
sakal-s wants to merge 1 commit intoanthropics:mainfrom
Conversation
The promise text extracted from output has whitespace normalized via perl (s/\s+/ /g), but the stored COMPLETION_PROMISE was compared as-is. If the user set a promise with multiple consecutive spaces (e.g. 'TASK DONE'), the comparison would always fail because the extracted text would be 'TASK DONE' while the stored value remained 'TASK DONE'. Normalize whitespace in the stored promise before comparing. Fixes anthropics#52405 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This was referenced Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
COMPLETION_PROMISEbefore comparing it to the extracted promise texts/\s+/ /g), but the stored value was not, causing comparison failures when the promise contained multiple consecutive spacesTest plan
--completion-promise "TASK DONE"<promise>TASK DONE</promise>(single space)Fixes #52405
🤖 Generated with Claude Code