Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions plugins/hookify/core/rule_engine.py
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,8 @@ def evaluate_rules(self, rules: List[Rule], input_data: Dict[str, Any]) -> Dict[
"reason": combined_message,
"systemMessage": combined_message
}
elif hook_event in ['PreToolUse', 'PostToolUse']:
elif hook_event == 'PreToolUse':
# PreToolUse can deny the tool before it executes
return {
"hookSpecificOutput": {
"hookEventName": hook_event,
Expand All @@ -78,7 +79,7 @@ def evaluate_rules(self, rules: List[Rule], input_data: Dict[str, Any]) -> Dict[
"systemMessage": combined_message
}
else:
# For other events, just show message
# PostToolUse and other events: tool already ran, can only inject a message
return {
"systemMessage": combined_message
}
Expand Down
4 changes: 3 additions & 1 deletion plugins/hookify/hooks/posttooluse.py
Original file line number Diff line number Diff line change
Expand Up @@ -35,11 +35,13 @@ def main():

# Determine event type based on tool
tool_name = input_data.get('tool_name', '')
event = None
if tool_name == 'Bash':
event = 'bash'
elif tool_name in ['Edit', 'Write', 'MultiEdit']:
event = 'file'
else:
# Unknown tool: only evaluate event=all rules.
event = 'all'

# Load rules
rules = load_rules(event=event)
Expand Down
5 changes: 4 additions & 1 deletion plugins/hookify/hooks/pretooluse.py
Original file line number Diff line number Diff line change
Expand Up @@ -42,11 +42,14 @@ def main():
# For PreToolUse, we use tool_name to determine "bash" vs "file" event
tool_name = input_data.get('tool_name', '')

event = None
if tool_name == 'Bash':
event = 'bash'
elif tool_name in ['Edit', 'Write', 'MultiEdit']:
event = 'file'
else:
# Unknown tool: only evaluate event=all rules to avoid
# bash/file-specific rules running on unrelated tools.
event = 'all'

# Load rules
rules = load_rules(event=event)
Expand Down