fix(workflows): correct pagination break condition and HTTP 2xx status check#68681
Closed
AZERDSQ131 wants to merge 1 commit into
Closed
fix(workflows): correct pagination break condition and HTTP 2xx status check#68681AZERDSQ131 wants to merge 1 commit into
AZERDSQ131 wants to merge 1 commit into
Conversation
- lock-closed-issues.yml: change `issues.length === 0` to `issues.length < 100` so the last partial page terminates the loop immediately instead of making an extra empty API call first - claude-dedupe-issues.yml: replace explicit `200 || 202` check with `>= 200 && < 300` to accept any 2xx success code (e.g. 201, 204) from the Statsig event endpoint Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Author
|
Closing: absorbed by #68682 which is a superset covering the same files |
This was referenced Jun 16, 2026
2 tasks
This was referenced Jun 16, 2026
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two workflow bugs fixed in this PR:
1.
lock-closed-issues.yml— Pagination break condition (line 44)Before:
After:
When the last page returns N < 100 issues, the loop would previously not break, making one extra API call that returns 0 results before stopping. With
< 100, the loop exits as soon as we receive a partial page — the standard pagination pattern used throughout the codebase.2.
claude-dedupe-issues.yml— HTTP status check (line 90)Before:
After:
The Statsig event endpoint may return other 2xx codes (e.g. 201, 204). The original check hardcoded only
200and202, causing valid successes to be logged as failures. The corrected check accepts the entire 2xx range per HTTP semantics.Test plan
lock-closed-issues.ymlexits the pagination loop correctly on a final partial pageclaude-dedupe-issues.ymlsuccess branch is taken for any 2xx response from Statsig🤖 Generated with Claude Code