fix(scripts/gh.sh): reject empty query for search issues command#68682
Open
AZERDSQ131 wants to merge 2 commits into
Open
fix(scripts/gh.sh): reject empty query for search issues command#68682AZERDSQ131 wants to merge 2 commits into
AZERDSQ131 wants to merge 2 commits into
Conversation
- lock-closed-issues.yml: change `issues.length === 0` to `issues.length < 100` so the last partial page terminates the loop immediately instead of making an extra empty API call first - claude-dedupe-issues.yml: replace explicit `200 || 202` check with `>= 200 && < 300` to accept any 2xx success code (e.g. 201, 204) from the Statsig event endpoint Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Without this guard, calling `./scripts/gh.sh search issues` or passing an empty string sends an unfiltered `gh search issues ""` request to the GitHub API, which returns thousands of results or an API error. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2 tasks
Open
3 tasks
Open
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.