fix(hookify): match file rules against Write tool content#69727
Open
clown6613 wants to merge 1 commit into
Open
fix(hookify): match file rules against Write tool content#69727clown6613 wants to merge 1 commit into
clown6613 wants to merge 1 commit into
Conversation
For an `event: file` simple-pattern rule, config_loader infers the field name `new_text`. In `_extract_field`, the `new_text`/`new_string` branch only read `tool_input['new_string']` (the Edit field), so it returned '' for the Write tool — whose content lives in `tool_input['content']`. As a result, file rules silently never fired when Claude created a new file via Write (e.g. the README's own "Warn About Debug Code" example). Mirror the adjacent `content` branch by falling back to `content` so both Write and Edit are covered. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This was referenced Jun 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
A simple-pattern hookify rule with
event: file(e.g. the README's "Warn About Debug Code" example,pattern: console\.log\() silently never fired when Claude created a new file via theWritetool.Root cause
config_loaderinfers the field namenew_textforevent: filesimple-pattern rules. Inrule_engine._extract_field, thenew_text/new_stringbranch only readtool_input['new_string'](the Edit field):The
Writetool stores file content intool_input['content'], so the branch returned''and the pattern never matched. The adjacentcontentbranch already does the right fallback.Fix
Verification
event: file,pattern: console\.log\(:content)new_string)