Fix potential integer overflow in sdsMakeRoomFor#186
Open
Luobao0318 wants to merge 1 commit intoantirez:masterfrom
Open
Fix potential integer overflow in sdsMakeRoomFor#186Luobao0318 wants to merge 1 commit intoantirez:masterfrom
Luobao0318 wants to merge 1 commit intoantirez:masterfrom
Conversation
Using a runtime check instead of assert to prevent heap overflow when NDEBUG is defined.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced the
assert()based overflow check insdsMakeRoomForwith a mandatory runtime check.The original assertion is stripped out in production builds when
NDEBUGis defined, leaving the code vulnerable to potential integer overflows and subsequent heap corruption. This patch keeps the overflow check active in all build configurations and returnsNULLwhen asize_toverflow is detected.