Skip to content

Update error-info-interpreter.js #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jessicamrbr wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Update error-info-interpreter.js #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a79a700
Update error-info-interpreter.js
jessicamrbr May 31, 2018
1165598
Update error-info-interpreter.js
jessicamrbr May 31, 2018
6e9f335
Update error-info-interpreter-tests.js
jessicamrbr May 31, 2018
84b43ee
Update error-info-interpreter.js
jessicamrbr May 31, 2018
1e3238c
Update error-info-interpreter.js
jessicamrbr May 31, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion lib/translator/error-info-interpreter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,20 @@ class ErrorInfoInterpreter {
code = err;
}
else if (err instanceof Error) {
code = err.message;
let parseOfMessage;

try {
parseOfMessage = JSON.parse(err.message);
} catch (e) {
parseOfMessage = err.message;
}

if (parseOfMessage instanceof Object) {
code = parseOfMessage.code;
custom = parseOfMessage.custom;
} else {
code = parseOfMessage;
}
}
else if (err instanceof Object) {
code = err.code;
Expand Down
14 changes: 14 additions & 0 deletions test/unit/lib/translator/error-info-interpreter-tests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,20 @@ describe('ErrorInfoInterpreter', function () {
errorInfo.should.have.property('code', code);
errorInfo.should.have.property('custom').which.is.Undefined();
});

it('should interpret an error thrown (string of json) as an error', function () {
let interpreter = new ErrorInfoInterpreter(errors);

let code = 'INVALID_REQUEST';
let custom = { data: 'anything' };

let errorInfo = interpreter.interpret(new Error(JSON.stringify({ code, custom })));

should.exist(errorInfo);
Object.keys(errorInfo).should.have.length(2);
errorInfo.should.have.property('code', code);
errorInfo.should.have.property('custom').which.is.Undefined();
});

it('should interpret an error thrown as an object', function () {
let interpreter = new ErrorInfoInterpreter(errors);
Expand Down