feat(generator): strictly regulate the syntax generation of GPT-Vis#959
Open
ninelcc336 wants to merge 2 commits into
Open
feat(generator): strictly regulate the syntax generation of GPT-Vis#959ninelcc336 wants to merge 2 commits into
ninelcc336 wants to merge 2 commits into
Conversation
Contributor
ninelcc336
commented
May 18, 2026
ninelcc336
commented
- 限制 LLM 输出的变量名必须为 visSyntax
- 约束 LLM 输出 visSyntax 内容的缩进格式
Contributor
|
🎊 PR Preview 16a0c51 has been successfully built and deployed to https://antvis-AVA-preview-pr-959.surge.sh 🕐 Build time: 0.042s
🤖 By surge-preview |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the GPT-Vis generation instructions and HTML template in src/visualization/generator.ts to enforce stricter formatting rules, such as prohibiting string interpolation and requiring specific indentation for the visSyntax variable. Review feedback correctly identifies that the use of triple backslashes for template string delimiters in both the instructions and the example code is incorrect and would lead to invalid JavaScript in the generated output; using a single escaped backtick is recommended instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.