improve(Histogram): Auto calculate range tickInterval by binWidth and binNumber#3486
Open
dengfuping wants to merge 3 commits into
Open
improve(Histogram): Auto calculate range tickInterval by binWidth and binNumber#3486dengfuping wants to merge 3 commits into
dengfuping wants to merge 3 commits into
Conversation
hustcc
approved these changes
May 22, 2023
Member
|
单侧似乎报错了。 |
Member
Author
单测一直没有跑完，看了下其他 PR 也是这样，是否是项目配置的问题？
|
Member
|
rebase 一下 master 应该可以运行了。 |
|
coordinate不能更新的问题能优化一下么 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR includes
Screenshot
binWidthis always same astickInterval. So auto calculating tickInterval is more convenient.binWidthis 2: