Fix npm publish job gating#18
Conversation
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 53 minutes and 45 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughUpdated four GitHub Actions workflows: removed Windows build dependency from npm publish, switched FAISS references from a commit SHA to tag Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.github/workflows/nightly.yml (1)
13-35: Consider pinning FAISS to an explicit commit SHA for stronger supply-chain guarantees.
FAISS_REF: v1.14.1is a lightweight tag (immutable), so it will not drift. However, for added supply-chain hardening in nightly builds, an explicit commit SHA (5622e93733b64b2e033362dbdfda019b2ab33ef0) would provide stronger guarantees against unexpected upstream changes.Optional hardening
env: FAISS_REF: v1.14.1 + FAISS_SHA: 5622e93733b64b2e033362dbdfda019b2ab33ef0 @@ git clone --branch "$FAISS_REF" --depth 1 https://github.com/facebookresearch/faiss.git /tmp/faiss cd /tmp/faiss + test "$(git rev-parse HEAD)" = "$FAISS_SHA" || exit 1🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/nightly.yml around lines 13 - 35, Replace the FAISS_REF tag with the explicit commit SHA suggested by the reviewer to pin the checkout to a single immutable commit: update the CI environment variable/constant FAISS_REF from "v1.14.1" to the commit SHA "5622e93733b64b2e033362dbdfda019b2ab33ef0" and ensure the git clone step that uses "$FAISS_REF" continues to reference that variable so the build/checkout in the "Build and install FAISS (CPU)" step always fetches the exact commit.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In @.github/workflows/nightly.yml:
- Around line 13-35: Replace the FAISS_REF tag with the explicit commit SHA
suggested by the reviewer to pin the checkout to a single immutable commit:
update the CI environment variable/constant FAISS_REF from "v1.14.1" to the
commit SHA "5622e93733b64b2e033362dbdfda019b2ab33ef0" and ensure the git clone
step that uses "$FAISS_REF" continues to reference that variable so the
build/checkout in the "Build and install FAISS (CPU)" step always fetches the
exact commit.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yml
Review profile: CHILL
Plan: Pro
Run ID: 481d8d6e-58f0-4f46-a938-3e04d8c694b9
📒 Files selected for processing (3)
.github/workflows/build-release.yml.github/workflows/codeql.yml.github/workflows/nightly.yml
1 participant
Summary
Validation
Note
This improves future tag releases. It does not retroactively change the already-queued run because that run uses the workflow from the tagged commit.
Summary by CodeRabbit