Skip to content

Specify paths for coverage #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anuraaga wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Specify paths for coverage #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,12 +75,12 @@ jobs:
uv run pyright

- name: run python tests
run: uv run pytest ${{ matrix.coverage == 'cov' && '--cov=connectrpc --cov-report=xml' || '' }}
run: uv run pytest ${{ matrix.coverage == 'cov' && '--cov=./src --cov-report=xml' || '' }}

- name: run conformance tests
# TODO: Debug stdin/stdout issues on Windows
if: ${{ !startsWith(matrix.os, 'windows-') }}
run: uv run pytest ${{ matrix.coverage == 'cov' && '--cov=connectrpc --cov-report=xml' || '' }}
run: uv run pytest ${{ matrix.coverage == 'cov' && '--cov=../src --cov-report=xml' || '' }}
working-directory: conformance

- name: run Go tests
Expand Down
4 changes: 1 addition & 3 deletions conformance/test/_util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,7 @@ def coverage_env(cov: Coverage | None) -> dict[str, str] | None:
if cov is None:
return None
env: dict[str, str] = {**os.environ}
# cov.config.source only contains . but we need .. too.
# It should be fine to just hard-code this.
env["COV_CORE_SOURCE"] = os.pathsep.join((".", ".."))
env["COV_CORE_SOURCE"] = os.pathsep.join(cov.config.source or ())
if cov.config.config_file:
env["COV_CORE_CONFIG"] = cov.config.config_file
if cov.config.data_file:
Expand Down