Skip to content

refactor: move encode HTML function into separate module#4591

Merged
qwerty541 merged 1 commit into
anuraghazra:masterfrom
qwerty541:refactor_move_encode_html_fn_into_sep_module
Oct 17, 2025
Merged

refactor: move encode HTML function into separate module#4591
qwerty541 merged 1 commit into
anuraghazra:masterfrom
qwerty541:refactor_move_encode_html_fn_into_sep_module

Conversation

@alexandr-garbuzov

Copy link
Copy Markdown
Contributor

No description provided.

@vercel

vercel Bot commented Oct 17, 2025

Copy link
Copy Markdown

@qwerty541 is attempting to deploy a commit to the github readme stats Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions Bot added repo-card Issues related to the pin/repo card. card-i18n Card text translations. gist-card labels Oct 17, 2025

@alexandr-garbuzov alexandr-garbuzov left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️

@qwerty541 qwerty541 requested a review from Copilot October 17, 2025 18:25

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the codebase by extracting the encodeHTML function from src/common/render.js into a new dedicated module src/common/html.js. This improves code organization by separating HTML encoding utility from rendering logic.

Key Changes

  • Created new src/common/html.js module containing the encodeHTML function
  • Updated all import statements across the codebase to reference the new module location
  • Removed encodeHTML export from src/common/render.js and src/common/index.js

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/common/html.js New module containing the extracted encodeHTML function with its documentation
src/common/render.js Removed encodeHTML function definition and export, added import from new module
src/common/index.js Removed encodeHTML re-export
src/common/Card.js Updated import to reference new html.js module, added type checking comment
src/common/fmt.js Updated import path for encodeHTML
src/translations.js Updated import path for encodeHTML
src/cards/repo.js Reorganized imports to separate encodeHTML import from render utilities
src/cards/gist.js Reorganized imports to separate encodeHTML import from render utilities
tests/render.test.js Split import statement to reflect new module structure

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@qwerty541 qwerty541 merged commit b240a06 into anuraghazra:master Oct 17, 2025
7 of 8 checks passed
@qwerty541 qwerty541 deleted the refactor_move_encode_html_fn_into_sep_module branch October 17, 2025 18:26
harryzcy pushed a commit to harryzcy/github-readme-stats that referenced this pull request Oct 18, 2025
pull Bot pushed a commit to T0biii/github-readme-stats that referenced this pull request Oct 18, 2025
martin-mfg pushed a commit to stats-organization/github-stats-extended that referenced this pull request Nov 2, 2025
ghosind pushed a commit to ghosind/github-readme-stats that referenced this pull request Dec 30, 2025
zimya pushed a commit to zimya/github-readme-stats-cf that referenced this pull request Jan 13, 2026
piscis pushed a commit to piscis/github-readme-stats that referenced this pull request Feb 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

card-i18n Card text translations. gist-card repo-card Issues related to the pin/repo card.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants