Skip to content

Proposal: provide a possibility of passing custom zoom factor to renderer (not graphics) #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nicky1038 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Proposal: provide a possibility of passing custom zoom factor to renderer (not graphics) #244

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 14 additions & 5 deletions src/View/renderer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@ var timer = require('../Utils/timer.js');
var getDimension = require('../Utils/getDimensions.js');
var dragndrop = require('../Input/dragndrop.js');

var zoomInFactor = Math.pow(1 + 0.4, 0.2);
var zoomOutFactor = Math.pow(1 + 0.4, -0.2);

/**
* This is heart of the rendering. Class accepts graph to be rendered and rendering settings.
* It monitors graph changes and depicts them accordingly.
Expand Down Expand Up @@ -130,13 +133,15 @@ function renderer(graph, settings) {
},

zoomOut: function() {
return scale(true);
return scale(zoomInFactor);
},

zoomIn: function() {
return scale(false);
return scale(zoomOutFactor);
},

scale: scale,

/**
* Returns current transformation matrix.
*/
Expand Down Expand Up @@ -421,16 +426,20 @@ function renderer(graph, settings) {
graph.off('changed', onGraphChanged);
}

function scale(out, scrollPoint) {
function scale(factor, scrollPoint) {
if (typeof factor !== 'number' || factor <= 0) {
return;
}

if (!scrollPoint) {
var containerSize = getDimension(container);
scrollPoint = {
x: containerSize.width / 2,
y: containerSize.height / 2
};
}
var scaleFactor = Math.pow(1 + 0.4, out ? -0.2 : 0.2);
transform.scale = graphics.scale(scaleFactor, scrollPoint);

transform.scale = graphics.scale(factor, scrollPoint);

renderGraph();
publicEvents.fire('scale', transform.scale);
Expand Down