Skip to content

feat: implement S3 block cleanup on file/space deletion#193

Open
marcolaux wants to merge 2 commits into
anyproto:mainfrom
marcolaux:feature/s3-block-cleanup
Open

feat: implement S3 block cleanup on file/space deletion#193
marcolaux wants to merge 2 commits into
anyproto:mainfrom
marcolaux:feature/s3-block-cleanup

Conversation

@marcolaux
Copy link
Copy Markdown

  • Implemented DeleteMany in s3store using batch deletion
  • Updated index service to return removed CIDs on FileUnbind and SpaceDelete
  • Updated deletion log to delete blocks from store when spaces are removed
  • Updated file node to delete blocks from store when files are deleted
  • Updated CID entry to remove key from Redis when refs count drops to zero

- Implemented DeleteMany in s3store using batch deletion
- Updated index service to return removed CIDs on FileUnbind and SpaceDelete
- Updated deletion log to delete blocks from store when spaces are removed
- Updated file node to delete blocks from store when files are deleted
- Updated CID entry to remove key from Redis when refs count drops to zero
@github-actions
Copy link
Copy Markdown

CLA Assistant Lite bot:
Thank you for your pull request, we really appreciate it!

Please sign our Contributor License Agreement before we can accept your contribution.
You can sign the CLA by simply commenting on this pull request with the following text.


I have read the CLA Document and I hereby sign the CLA


Marco Laux seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request

@marcolaux
Copy link
Copy Markdown
Author

I hereby grant Any Association and its successors or assignees permission to use, copy, modify, distribute, and sub-license my contributions on any terms they like, under all my rights in my contributions. A contribution includes anything I submit to the project. I am giving them this license in order to make it possible for them to accept my contributions into their project.

As far as the law allows, my contributions come as is, without any warranty or condition, and I will not be liable to anyone for any damages related to this software or this license, under any kind of legal claim.

@marcolaux marcolaux closed this Dec 11, 2025
@marcolaux marcolaux reopened this Dec 11, 2025
- Updated persistentStore interface to include DeleteMany
- Updated CheckDeletedSpaces to call DeleteMany on S3 store for deleted spaces
- Updated CheckDeletedSpaces test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant