chore(api): adapt to main after rebase (writeProjectError arity, apispec API, regen)

Rebased onto main, which landed several changes that intersect this branch:

- writeProjectError is now 3-arg (status derived from project.Error.Kind); the
  get handler's degenerate-GetResult guard now calls the 3-arg form.
- apispec.Spec dropped its YAML() method; add apispec.Embedded() returning the
  raw embedded bytes, used by the generator's drift + route-parity tests.
- #62 removed Runtime/Reactions/ReactionConfig from the project types, so the
  regenerated openapi.yaml (and frontend schema.d.ts) drop those, and the dead
  ReactionConfig entry is removed from the schema-name map.
- CI go.yml: keep main's new golangci-lint `lint` job alongside the gen-verify
  job, both reading the Go version from go.mod.

go build/vet/test all pass; spec + TS regenerate with no drift; gofmt clean.

Author: i-trytoohard

backend/internal/httpd/apispec/apispec.go

@@ -64,6 +64,11 @@ func New(yamlBytes []byte) (*Spec, error) {
 	return &Spec{doc: doc}, nil
 }
 
+// Embedded returns the raw bytes of the committed, embedded openapi.yaml. The
+// code-first generator's drift and route-parity tests compare against it
+// (specgen.Build() must equal these bytes); ServeYAML writes the same bytes.
+func Embedded() []byte { return openapiYAML }
+
 // Operation returns the spec slice for a single (method, path) pair, ready
 // to be JSON-serialised. The slice is the OpenAPI Operation object (the
 // inner block under e.g. paths./projects.get), with parent path-level

backend/internal/httpd/apispec/openapi.yaml

@@ -314,14 +314,8 @@ components:
           type: string
         path:
           type: string
-        reactions:
-          additionalProperties:
-            $ref: '#/components/schemas/ReactionConfig'
-          type: object
         repo:
           type: string
-        runtime:
-          type: string
         scm:
           $ref: '#/components/schemas/SCMConfig'
         tracker:
@@ -358,30 +352,6 @@ components:
       required:
       - project
       type: object
-    ReactionConfig:
-      properties:
-        action:
-          type: string
-        auto:
-          type:
-          - "null"
-          - boolean
-        escalateAfter: {}
-        includeSummary:
-          type:
-          - "null"
-          - boolean
-        message:
-          type: string
-        priority:
-          type: string
-        retries:
-          type:
-          - "null"
-          - integer
-        threshold:
-          type: string
-      type: object
     ReloadResult:
       properties:
         degradedCount:
@@ -465,16 +435,6 @@ components:
           type:
           - "null"
           - string
-        reactions:
-          additionalProperties:
-            $ref: '#/components/schemas/ReactionConfig'
-          type:
-          - "null"
-          - object
-        runtime:
-          type:
-          - "null"
-          - string
         scm:
           $ref: '#/components/schemas/SCMConfig'
         tracker:

backend/internal/httpd/apispec/parity_test.go

@@ -48,7 +48,7 @@ func TestRouteSpecParity(t *testing.T) {
 	var doc struct {
 		Paths map[string]map[string]yaml.Node `yaml:"paths"`
 	}
-	if err := yaml.Unmarshal(apispec.Default().YAML(), &doc); err != nil {
+	if err := yaml.Unmarshal(apispec.Embedded(), &doc); err != nil {
 		t.Fatalf("parse spec: %v", err)
 	}
 	httpMethods := map[string]bool{"get": true, "post": true, "put": true, "patch": true, "delete": true}

backend/internal/httpd/apispec/specgen/build.go

@@ -125,7 +125,6 @@ var schemaNames = map[string]string{
 	"ProjectTrackerConfig":     "TrackerConfig",
 	"ProjectSCMConfig":         "SCMConfig",
 	"ProjectSCMWebhookConfig":  "SCMWebhookConfig",
-	"ProjectReactionConfig":    "ReactionConfig",
 }
 
 // markRequestBodyRequired sets requestBody.required: true on the operation's

backend/internal/httpd/apispec/specgen/build_test.go

@@ -16,7 +16,7 @@ func TestBuild_MatchesEmbedded(t *testing.T) {
 	if err != nil {
 		t.Fatalf("Build: %v", err)
 	}
-	embedded := apispec.Default().YAML()
+	embedded := apispec.Embedded()
 	if !bytes.Equal(got, embedded) {
 		t.Fatalf("embedded openapi.yaml is stale — run `go generate ./...` and commit.\n"+
 			"len(fresh)=%d len(embedded)=%d", len(got), len(embedded))

backend/internal/httpd/controllers/projects.go

@@ -87,8 +87,9 @@ func (c *ProjectsController) get(w http.ResponseWriter, r *http.Request) {
 	resp, err := newGetProjectResponse(got)
 	if err != nil {
 		// GetResult set neither variant — a Manager-contract violation. Map it
-		// to a 500 here, before any status/body is written.
-		writeProjectError(w, r, err, http.StatusInternalServerError)
+		// to a 500 here, before any status/body is written. A plain error (not
+		// *project.Error) falls through writeProjectError to a 500 envelope.
+		writeProjectError(w, r, err)
 		return
 	}
 	envelope.WriteJSON(w, http.StatusOK, resp)

frontend/src/api/schema.d.ts

@@ -108,11 +108,7 @@ export interface components {
             id: string;
             name: string;
             path: string;
-            reactions?: {
-                [key: string]: components["schemas"]["ReactionConfig"];
-            };
             repo: string;
-            runtime?: string;
             scm?: components["schemas"]["SCMConfig"];
             tracker?: components["schemas"]["TrackerConfig"];
         };
@@ -125,16 +121,6 @@ export interface components {
         ProjectResponse: {
             project: components["schemas"]["Project"];
         };
-        ReactionConfig: {
-            action?: string;
-            auto?: null | boolean;
-            escalateAfter?: unknown;
-            includeSummary?: null | boolean;
-            message?: string;
-            priority?: string;
-            retries?: null | number;
-            threshold?: string;
-        };
         ReloadResult: {
             degradedCount: number;
             projectCount: number;
@@ -172,10 +158,6 @@ export interface components {
         };
         UpdateConfigInput: {
             agent?: null | string;
-            reactions?: null | {
-                [key: string]: components["schemas"]["ReactionConfig"];
-            };
-            runtime?: null | string;
             scm?: components["schemas"]["SCMConfig"];
             tracker?: components["schemas"]["TrackerConfig"];
         };