refactor: move session status assembly to service (#62)

Author: i-trytoohard

README.md

@@ -4,7 +4,7 @@ Rewrite of the agent-orchestrator: a long-running Go backend daemon (`backend/`)
 paired with a placeholder Electron + TypeScript frontend shell (`frontend/`).
 
 See [`docs/`](docs/README.md) for architecture and status — start with the
-Lifecycle Manager + Session Manager lane in [`docs/architecture.md`](docs/architecture.md).
+Lifecycle Manager + Session Service lane in [`docs/architecture.md`](docs/architecture.md).
 
 ## Backend daemon
 

backend/internal/domain/status.go

@@ -19,52 +19,3 @@ const (
 	StatusIdle             SessionStatus = "idle"
 	StatusTerminated       SessionStatus = "terminated"
 )
-
-// DeriveStatus is the ONLY producer of display status. It is a pure function of
-// persisted session facts and PR facts: is_terminated, activity_state, and the PR
-// table are the durable facts that tell the UI what it needs to know.
-func DeriveStatus(rec SessionRecord, pr *PRFacts) SessionStatus {
-	if rec.IsTerminated {
-		if pr != nil && pr.Merged {
-			return StatusMerged
-		}
-		return StatusTerminated
-	}
-
-	if rec.Activity.State == ActivityWaitingInput {
-		return StatusNeedsInput
-	}
-
-	if pr != nil {
-		if pr.Merged {
-			return StatusMerged
-		}
-		if !pr.Closed {
-			return prPipelineStatus(*pr)
-		}
-	}
-
-	if rec.Activity.State == ActivityActive {
-		return StatusWorking
-	}
-	return StatusIdle
-}
-
-func prPipelineStatus(pr PRFacts) SessionStatus {
-	switch {
-	case pr.CI == CIFailing:
-		return StatusCIFailed
-	case pr.Draft:
-		return StatusDraft
-	case pr.Review == ReviewChangesRequest || pr.ReviewComments:
-		return StatusChangesRequested
-	case pr.Mergeability == MergeMergeable:
-		return StatusMergeable
-	case pr.Review == ReviewApproved:
-		return StatusApproved
-	case pr.Review == ReviewRequired:
-		return StatusReviewPending
-	default:
-		return StatusPROpen
-	}
-}

backend/internal/domain/status_test.go

@@ -19,13 +19,15 @@ import (
 // registered but returns the OpenAPI-backed 501 response.
 type APIDeps struct {
 	Projects project.Manager
+	Sessions controllers.SessionService
 }
 
 // API owns one controller per resource and is the single Register call the
 // router invokes to mount the /api/v1 surface.
 type API struct {
 	cfg      config.Config
 	projects *controllers.ProjectsController
+	sessions *controllers.SessionsController
 }
 
 // NewAPI constructs the API surface from its dependencies. cfg carries the
@@ -37,6 +39,9 @@ func NewAPI(cfg config.Config, deps APIDeps) *API {
 		projects: &controllers.ProjectsController{
 			Mgr: deps.Projects,
 		},
+		sessions: &controllers.SessionsController{
+			Svc: deps.Sessions,
+		},
 	}
 }
 
@@ -55,6 +60,7 @@ func (a *API) Register(root chi.Router) {
 		r.Group(func(r chi.Router) {
 			r.Use(middleware.Timeout(timeout))
 			a.projects.Register(r)
+			a.sessions.Register(r)
 			// Sibling REST controllers plug in here.
 		})
 		// Surfaces that intentionally bypass the REST timeout register at this level.