pass a logger and a task schedular to handlers#300
Open
craigrose wants to merge 5 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces dependency injection for handlers by allowing an external logger and a task “schedular”/scheduler to be passed in, enabling custom scheduling of batch processing instead of always creating a Dask cluster.
Changes:
- Allow
CommonHandler(and factorycloud_optimised_creation) to accept a provided logger instead of always creating one. - Add a
schedularhook toCommonHandlerand use it inGenericParquetHandler.to_cloud_optimised()to schedule batch tasks externally. - Add defensive handling around logger handler cleanup in
GenericParquetHandler.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| aodn_cloud_optimised/lib/GenericParquetHandler.py | Adds optional external scheduling path and adjusts logger handler cleanup logic. |
| aodn_cloud_optimised/lib/CommonHandler.py | Adds logger injection, plumbs schedular kwarg through handler creation, and updates logger selection logic. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+96
to
100
| self.logger = kwargs.get("logger", None) | ||
| if not self.logger: | ||
| logger_name = self.dataset_config.get("logger_name", "generic") | ||
| self.logger = get_logger(logger_name, raise_error=self.raise_error) | ||
|
|
Comment on lines
+690
to
+694
| if not logger: | ||
| logger_name = dataset_config.get("logger_name", "generic") | ||
| logger = get_logger(logger_name, raise_error=kwargs.get("raise_error", False)) | ||
| else: | ||
| kwargs_handler_class["logger"] = logger |
Comment on lines
+1668
to
+1671
| try: | ||
| self.logger.handlers.clear() | ||
| except AttributeError: | ||
| pass |
| logger=self.logger, | ||
| ) | ||
|
|
||
| self.schedular = kwargs.get("schedular", None) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.