Fix/diver index column config#304
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes configuration/CLI entrypoints for several datasets that are no longer tracked by aodn_cloud_optimised, and updates multiple diver dataset configs to include an index field in the schema to prevent conversion-time “missing variable” errors during Parquet generation.
Changes:
- Removed
pyproject.tomlscript entrypoints for datasets that are being de-scoped. - Added an
indexfield to the schema of multiple diver Parquet dataset configs. - Deleted dataset configuration JSONs for aggregated_*_nonqc and amsa_vessel_tracking.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| pyproject.toml | Removes script entrypoints for de-scoped datasets; may require follow-up cleanup of in-repo references. |
| aodn_cloud_optimised/config/dataset/diver_survey_metadata_qc.json | Adds index to schema to avoid “missing variable” errors during dataframe/xarray conversion. |
| aodn_cloud_optimised/config/dataset/diver_site_information_qc.json | Adds index to schema to avoid “missing variable” errors during dataframe/xarray conversion. |
| aodn_cloud_optimised/config/dataset/diver_reef_fish_abundance_biomass_qc.json | Adds index to schema to avoid “missing variable” errors during dataframe/xarray conversion. |
| aodn_cloud_optimised/config/dataset/diver_off_transect_species_observations_qc.json | Adds index to schema to avoid “missing variable” errors during dataframe/xarray conversion. |
| aodn_cloud_optimised/config/dataset/diver_mobile_macroinvertebrate_abundance_qc.json | Adds index to schema to avoid “missing variable” errors during dataframe/xarray conversion. |
| aodn_cloud_optimised/config/dataset/diver_cryptobenthic_fish_abundance_qc.json | Adds index to schema to avoid “missing variable” errors during dataframe/xarray conversion. |
| aodn_cloud_optimised/config/dataset/diver_benthic_cover_in_situ_qc.json | Adds index to schema to avoid “missing variable” errors during dataframe/xarray conversion. |
| aodn_cloud_optimised/config/dataset/amsa_vessel_tracking.json | Deleted dataset config (dataset de-scoped). |
| aodn_cloud_optimised/config/dataset/aggregated_seagrass_nonqc.json | Deleted dataset config (dataset de-scoped). |
| aodn_cloud_optimised/config/dataset/aggregated_seabird_nonqc.json | Deleted dataset config (dataset de-scoped). |
| aodn_cloud_optimised/config/dataset/aggregated_kelp_nonqc.json | Deleted dataset config (dataset de-scoped). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| [project.scripts] | ||
| #cloud_optimised_srs_oc_ljco_to_parquet = "aodn_cloud_optimised.bin.srs_oc_ljco_to_parquet:main" | ||
| aodn-mcp-server = "aodn_cloud_optimised.mcp.server:main" | ||
| cloud_optimised_aggregated_kelp_nonqc = "aodn_cloud_optimised.bin.datasets.aggregated_kelp_nonqc:main" | ||
| cloud_optimised_aggregated_seabird_nonqc = "aodn_cloud_optimised.bin.datasets.aggregated_seabird_nonqc:main" | ||
| cloud_optimised_aggregated_seagrass_nonqc = "aodn_cloud_optimised.bin.datasets.aggregated_seagrass_nonqc:main" | ||
| cloud_optimised_amsa_vessel_tracking = "aodn_cloud_optimised.bin.datasets.amsa_vessel_tracking:main" | ||
| cloud_optimised_animal_acoustic_tracking_delayed_qc = "aodn_cloud_optimised.bin.datasets.animal_acoustic_tracking_delayed_qc:main" | ||
| cloud_optimised_animal_ctd_satellite_relay_tagging_delayed_qc = "aodn_cloud_optimised.bin.datasets.animal_ctd_satellite_relay_tagging_delayed_qc:main" |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
|
https://gh.io/copilot-coding-agent-docs the notebooks are fine to leave. @copilot Please unwire the testing references and run the test suite to confirm changes. |
Removed |
Deleted non
aodn_cloud_optimisedtracked datasetsAlso deleted their script counterparts in the
pyproject.tomlAdded index to diver datasets
indexis a required variable to not get a noisy error that kills the data generation process.Adding an empty
indexresolves this issue.Validated on all datasets locally.