Skip to content

Fix/diver index column config#304

Open
thommodin wants to merge 5 commits into
mainfrom
fix/diver-index-column-config
Open

Fix/diver index column config#304
thommodin wants to merge 5 commits into
mainfrom
fix/diver-index-column-config

Conversation

@thommodin

Copy link
Copy Markdown
Contributor

Deleted non aodn_cloud_optimised tracked datasets

Also deleted their script counterparts in the pyproject.toml

Added index to diver datasets

index is a required variable to not get a noisy error that kills the data generation process.

Adding an empty index resolves this issue.

Validated on all datasets locally.

Copilot AI review requested due to automatic review settings July 10, 2026 05:59

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes configuration/CLI entrypoints for several datasets that are no longer tracked by aodn_cloud_optimised, and updates multiple diver dataset configs to include an index field in the schema to prevent conversion-time “missing variable” errors during Parquet generation.

Changes:

  • Removed pyproject.toml script entrypoints for datasets that are being de-scoped.
  • Added an index field to the schema of multiple diver Parquet dataset configs.
  • Deleted dataset configuration JSONs for aggregated_*_nonqc and amsa_vessel_tracking.

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 8 comments.

Show a summary per file
File Description
pyproject.toml Removes script entrypoints for de-scoped datasets; may require follow-up cleanup of in-repo references.
aodn_cloud_optimised/config/dataset/diver_survey_metadata_qc.json Adds index to schema to avoid “missing variable” errors during dataframe/xarray conversion.
aodn_cloud_optimised/config/dataset/diver_site_information_qc.json Adds index to schema to avoid “missing variable” errors during dataframe/xarray conversion.
aodn_cloud_optimised/config/dataset/diver_reef_fish_abundance_biomass_qc.json Adds index to schema to avoid “missing variable” errors during dataframe/xarray conversion.
aodn_cloud_optimised/config/dataset/diver_off_transect_species_observations_qc.json Adds index to schema to avoid “missing variable” errors during dataframe/xarray conversion.
aodn_cloud_optimised/config/dataset/diver_mobile_macroinvertebrate_abundance_qc.json Adds index to schema to avoid “missing variable” errors during dataframe/xarray conversion.
aodn_cloud_optimised/config/dataset/diver_cryptobenthic_fish_abundance_qc.json Adds index to schema to avoid “missing variable” errors during dataframe/xarray conversion.
aodn_cloud_optimised/config/dataset/diver_benthic_cover_in_situ_qc.json Adds index to schema to avoid “missing variable” errors during dataframe/xarray conversion.
aodn_cloud_optimised/config/dataset/amsa_vessel_tracking.json Deleted dataset config (dataset de-scoped).
aodn_cloud_optimised/config/dataset/aggregated_seagrass_nonqc.json Deleted dataset config (dataset de-scoped).
aodn_cloud_optimised/config/dataset/aggregated_seabird_nonqc.json Deleted dataset config (dataset de-scoped).
aodn_cloud_optimised/config/dataset/aggregated_kelp_nonqc.json Deleted dataset config (dataset de-scoped).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread aodn_cloud_optimised/config/dataset/diver_survey_metadata_qc.json
Comment thread aodn_cloud_optimised/config/dataset/diver_site_information_qc.json
Comment thread pyproject.toml
Comment on lines 138 to 142
[project.scripts]
#cloud_optimised_srs_oc_ljco_to_parquet = "aodn_cloud_optimised.bin.srs_oc_ljco_to_parquet:main"
aodn-mcp-server = "aodn_cloud_optimised.mcp.server:main"
cloud_optimised_aggregated_kelp_nonqc = "aodn_cloud_optimised.bin.datasets.aggregated_kelp_nonqc:main"
cloud_optimised_aggregated_seabird_nonqc = "aodn_cloud_optimised.bin.datasets.aggregated_seabird_nonqc:main"
cloud_optimised_aggregated_seagrass_nonqc = "aodn_cloud_optimised.bin.datasets.aggregated_seagrass_nonqc:main"
cloud_optimised_amsa_vessel_tracking = "aodn_cloud_optimised.bin.datasets.amsa_vessel_tracking:main"
cloud_optimised_animal_acoustic_tracking_delayed_qc = "aodn_cloud_optimised.bin.datasets.animal_acoustic_tracking_delayed_qc:main"
cloud_optimised_animal_ctd_satellite_relay_tagging_delayed_qc = "aodn_cloud_optimised.bin.datasets.animal_ctd_satellite_relay_tagging_delayed_qc:main"
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@thommodin

Copy link
Copy Markdown
Contributor Author

https://gh.io/copilot-coding-agent-docs the notebooks are fine to leave.

@copilot Please unwire the testing references and run the test suite to confirm changes.

Copilot AI commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

https://gh.io/copilot-coding-agent-docs the notebooks are fine to leave.

@copilot Please unwire the testing references and run the test suite to confirm changes.

Removed aggregated_kelp_nonqc.json, aggregated_seabird_nonqc.json, aggregated_seagrass_nonqc.json, and amsa_vessel_tracking.json from _PLACEHOLDER_CONFIGS in test_aodn_cloud_optimised/test_config.py — these were the only test references to the deleted configs. Notebooks left as-is per your note. CI will confirm the suite is green.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants