remove diver_photoquadrat_score_qc config#309
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the dataset configuration for diver_photoquadrat_score_qc, which affects how the library locates and loads this dataset’s config from the packaged config/dataset/ directory.
Changes:
- Deletes
aodn_cloud_optimised/config/dataset/diver_photoquadrat_score_qc.json(full removal of dataset config, schema, and AWS Open Data Registry metadata block).
Comments suppressed due to low confidence (1)
aodn_cloud_optimised/config/dataset/diver_photoquadrat_score_qc.json:1
- Removing this dataset config will make
load_dataset_config('diver_photoquadrat_score_qc')raiseFileNotFoundError(aodn_cloud_optimised/lib/config.py:152-159). The repo still advertises/links this dataset elsewhere (e.g.,cloud_optimised_diver_photoquadrat_score_qcconsole-script in pyproject.toml:158 and the notebooks/README.md entry for diver_photoquadrat_score_qc.ipynb), so consumers may now hit runtime errors or stale documentation. Either keep a minimal config/redirect, or remove/update those references as part of this change so the package surface stays consistent.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
|
@leonardolaiolo, does it have any implications for the AWS registry, notebooks or any other potential places where this config/product might be called? |
Contributor
Author
|
It could, but this specific config that has been removed was a new one and not an existing one being modified, so i think we're all good :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
remove diver_photoquadrat_score_qc config as clashes with NESP generated product.