Skip to content

remove diver_photoquadrat_score_qc config#309

Merged
thommodin merged 1 commit into
mainfrom
remove_diver_photoquadrat_score_qc
Jul 15, 2026
Merged

remove diver_photoquadrat_score_qc config#309
thommodin merged 1 commit into
mainfrom
remove_diver_photoquadrat_score_qc

Conversation

@leonardolaiolo

@leonardolaiolo leonardolaiolo commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

remove diver_photoquadrat_score_qc config as clashes with NESP generated product.

Copilot AI review requested due to automatic review settings July 15, 2026 03:34
@leonardolaiolo leonardolaiolo requested a review from thommodin July 15, 2026 03:35

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the dataset configuration for diver_photoquadrat_score_qc, which affects how the library locates and loads this dataset’s config from the packaged config/dataset/ directory.

Changes:

  • Deletes aodn_cloud_optimised/config/dataset/diver_photoquadrat_score_qc.json (full removal of dataset config, schema, and AWS Open Data Registry metadata block).
Comments suppressed due to low confidence (1)

aodn_cloud_optimised/config/dataset/diver_photoquadrat_score_qc.json:1

  • Removing this dataset config will make load_dataset_config('diver_photoquadrat_score_qc') raise FileNotFoundError (aodn_cloud_optimised/lib/config.py:152-159). The repo still advertises/links this dataset elsewhere (e.g., cloud_optimised_diver_photoquadrat_score_qc console-script in pyproject.toml:158 and the notebooks/README.md entry for diver_photoquadrat_score_qc.ipynb), so consumers may now hit runtime errors or stale documentation. Either keep a minimal config/redirect, or remove/update those references as part of this change so the package surface stays consistent.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@thommodin thommodin merged commit adf1f4d into main Jul 15, 2026
8 checks passed
@thommodin thommodin deleted the remove_diver_photoquadrat_score_qc branch July 15, 2026 03:59
@evacougnon

Copy link
Copy Markdown
Collaborator

@leonardolaiolo, does it have any implications for the AWS registry, notebooks or any other potential places where this config/product might be called?

@leonardolaiolo

Copy link
Copy Markdown
Contributor Author

It could, but this specific config that has been removed was a new one and not an existing one being modified, so i think we're all good :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants