feat(#1828): Expose NetworkConnector URI and local URI in JMX MBean

Add getUri() and getLocalUri() attributes to NetworkConnectorViewMBean
so that the network connector URI is visible via JMX. Add abstract
getUri() to NetworkConnector base class and implement it in
MulticastNetworkConnector.

Author: jbonofre

activemq-broker/src/main/java/org/apache/activemq/broker/jmx/NetworkConnectorView.java

@@ -16,6 +16,8 @@
  */
 package org.apache.activemq.broker.jmx;
 
+import java.net.URISyntaxException;
+
 import org.apache.activemq.network.NetworkConnector;
 
 public class NetworkConnectorView implements NetworkConnectorViewMBean {
@@ -37,6 +39,20 @@ public void stop() throws Exception {
         connector.stop();
     }
 
+    @Override
+    public String getUri() {
+        return connector.getUri() != null ? connector.getUri().toString() : "";
+    }
+
+    @Override
+    public String getLocalUri() {
+        try {
+            return connector.getLocalUri() != null ? connector.getLocalUri().toString() : "";
+        } catch (URISyntaxException e) {
+            return "";
+        }
+    }
+
     @Override
     public String getName() {
         return connector.getName();

activemq-broker/src/main/java/org/apache/activemq/broker/jmx/NetworkConnectorViewMBean.java

@@ -20,6 +20,10 @@
 
 public interface NetworkConnectorViewMBean extends Service {
 
+    String getUri();
+
+    String getLocalUri();
+
     String getName();
 
     int getMessageTTL();

activemq-broker/src/main/java/org/apache/activemq/network/MulticastNetworkConnector.java

@@ -77,6 +77,11 @@ public void setRemoteTransport(Transport remoteTransport) {
         this.remoteTransport = remoteTransport;
     }
 
+    @Override
+    public URI getUri() {
+        return remoteURI;
+    }
+
     public URI getRemoteURI() {
         return remoteURI;
     }

activemq-broker/src/main/java/org/apache/activemq/network/NetworkConnector.java

@@ -77,6 +77,8 @@ public NetworkConnector(URI localURI) {
         this.localURI = localURI;
     }
 
+    public abstract URI getUri();
+
     public URI getLocalUri() throws URISyntaxException {
         return localURI;
     }

activemq-unit-tests/src/test/java/org/apache/activemq/jmx/JmxCreateNCTest.java

@@ -66,5 +66,7 @@ public void testBridgeRegistration() throws Exception {
 
         assertNotNull(nc);
         assertEquals("NC", nc.getName());
+        assertEquals("static:(tcp://localhost:61617)", nc.getUri());
+        assertNotNull(nc.getLocalUri());
     }
 }