[#] Fix flaky test: ActiveDurableSubscriptionBrowseExpireTest.java

Author: mattrpav

activemq-unit-tests/src/test/java/org/apache/activemq/usecases/ActiveDurableSubscriptionBrowseExpireTest.java

@@ -18,6 +18,7 @@
 
 import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.assertNotNull;
+import static org.junit.Assert.assertTrue;
 
 import java.io.IOException;
 import java.util.Arrays;
@@ -40,6 +41,7 @@
 import org.apache.activemq.store.TopicMessageStore;
 import org.apache.activemq.broker.region.Destination;
 import org.apache.activemq.command.MessageId;
+import org.apache.activemq.util.Wait;
 import org.junit.Test;
 import org.junit.runner.RunWith;
 import org.junit.runners.Parameterized;
@@ -144,8 +146,13 @@ public boolean isDuplicate(MessageId id) {
         // browse (should | should not) expire the messages on the destination if expiration is (enabled | not enabled)
         data = sub.browse();
         assertNotNull(data);
-        assertEquals(enableExpiration ? messagesToExpire.size() : 0, dest.getDestinationStatistics().getExpired().getCount());
-        
+
+        if(enableExpiration) {
+            assertTrue(Wait.waitFor(() -> dest.getDestinationStatistics().getExpired().getCount() == messagesToExpire.size(), 5_000, 100));
+        } else {
+            assertEquals(Long.valueOf(0), Long.valueOf(dest.getDestinationStatistics().getExpired().getCount()));
+        }
+
         session.close();
         con.close();
     }